-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove VPN services; only install after customer purchases #20754
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 204d2b2 - Browse repository at this point
Copy the full SHA 204d2b2View commit details -
Remove
BraveVpnService
andBraveVpnWireguardService
from servicesThis code runs when mini-installer executes for system level installs. The install worker is executed for new users but also runs on each upgrade. This is the first part of the fix, helping solve brave/brave-browser#33726 The second part of the fix will be to install the services when needed (and is a bit tricky).
Configuration menu - View commit details
-
Copy full SHA for 93d7b50 - Browse repository at this point
Copy the full SHA 93d7b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40e87b2 - Browse repository at this point
Copy the full SHA 40e87b2View commit details -
Updated interface IDs for all items in elevation_service_idl.idl
This also created a new interface for Development (not in upstream) This service is not used by Brave currently, but it's in use by Chrome. We don't want to have conflicts with the IDs. Updated IID for elevation service in registration (in install_static) Updates service naming logic to take channel into account
Configuration menu - View commit details
-
Copy full SHA for 6881bb5 - Browse repository at this point
Copy the full SHA 6881bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19e5811 - Browse repository at this point
Copy the full SHA 19e5811View commit details -
Configuration menu - View commit details
-
Copy full SHA for 547e0d9 - Browse repository at this point
Copy the full SHA 547e0d9View commit details -
NOTE: this is only used on system installs This method will check for Brave VPN services and if they are not present it will install them. This will only happen if the person is a Brave VPN customer and has credentials.
Configuration menu - View commit details
-
Copy full SHA for e628446 - Browse repository at this point
Copy the full SHA e628446View commit details -
Replace MIDL files before build
Moves the IDL file into chromium_src, patches BUILD.gn to use chromium_src override. IDL output rebuilt at `./src` directory using `python3 ./tools/win/update_idl.py` Using #109 as a guide Also includes `.gitattributes` fix which prevents differences found w/ filecmp.cmpfiles in MIDL compilation.
Configuration menu - View commit details
-
Copy full SHA for 06952fd - Browse repository at this point
Copy the full SHA 06952fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05b217e - Browse repository at this point
Copy the full SHA 05b217eView commit details -
Move brave_vpn_helper install methods to
brave/installer/win/util/
An attempt to clean up layer violations Also includes update to `GetVpnHelperServiceProfileDir` (`brave_vpn_helper_utils.cc`) to use std::wstring to avoid additional base::UTF8ToWide call.
Configuration menu - View commit details
-
Copy full SHA for baca65b - Browse repository at this point
Copy the full SHA baca65bView commit details -
Cleanup elevation service integration
- Deleted elevator patch files - Deleted chrome/elevation_service deps from components - Updated elevation_service BUILD.gn patches
Configuration menu - View commit details
-
Copy full SHA for 9398c34 - Browse repository at this point
Copy the full SHA 9398c34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d5d7c0 - Browse repository at this point
Copy the full SHA 7d5d7c0View commit details -
Move
InstallSystemServices
toBraveVPNOSConnectionAPI
and throttleThis will only allow for one call at a time AND will only allow for one successful run per browser-open. Subsequent calls to `InstallSystemServices` will no-op.
Configuration menu - View commit details
-
Copy full SHA for 2285e61 - Browse repository at this point
Copy the full SHA 2285e61View commit details -
Persist value after Windows service removal; don't run more than once.
Includes unit tests.
Configuration menu - View commit details
-
Copy full SHA for 0bba08a - Browse repository at this point
Copy the full SHA 0bba08aView commit details -
Paths were differing depending on if called from elevation_service.exe or brave.exe. There was also logic with official build. This simplifies it all. Tested install does the removal and that buying VPN installs the services
Configuration menu - View commit details
-
Copy full SHA for 128fc40 - Browse repository at this point
Copy the full SHA 128fc40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 942d0fd - Browse repository at this point
Copy the full SHA 942d0fdView commit details -
Rename
IsWireguardServiceRegistered
toIsWireguardServiceInstalled
Matches the `*Installed` check used by VPN helper service
Configuration menu - View commit details
-
Copy full SHA for 88826bc - Browse repository at this point
Copy the full SHA 88826bcView commit details -
Move service installation method into brave/browser
Method is now passed in when connection object is created in browser process.
Configuration menu - View commit details
-
Copy full SHA for 7d1d7bb - Browse repository at this point
Copy the full SHA 7d1d7bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 389d2ec - Browse repository at this point
Copy the full SHA 389d2ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for b299eb0 - Browse repository at this point
Copy the full SHA b299eb0View commit details -
Move VPN service installation over to elevation service
Updates code to use that code too (removing from the service). This also removes installation that could happen on brave://settings/system This settings install use-case is obsolete now because the services will be installed once VPN is actually in use. This use-case would only happen if the person had VPN but it was set to IKEv2 and they did not have the services installed. For example, a user install (not a system install).
Configuration menu - View commit details
-
Copy full SHA for ae5f61f - Browse repository at this point
Copy the full SHA ae5f61fView commit details -
Handling connect request while system service installing in-progress
When system service installing is in-progress, wait till it's completed and connect again.
Configuration menu - View commit details
-
Copy full SHA for 4ed091a - Browse repository at this point
Copy the full SHA 4ed091aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29290d1 - Browse repository at this point
Copy the full SHA 29290d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce8bb65 - Browse repository at this point
Copy the full SHA ce8bb65View commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 27801b8 - Browse repository at this point
Copy the full SHA 27801b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ef9ef2 - Browse repository at this point
Copy the full SHA 6ef9ef2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eec327 - Browse repository at this point
Copy the full SHA 5eec327View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e500ff - Browse repository at this point
Copy the full SHA 1e500ffView commit details