Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VPN services; only install after customer purchases #20754

Merged
merged 28 commits into from
Jan 18, 2024

Commits on Jan 16, 2024

  1. Fix misspelling

    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    204d2b2 View commit details
    Browse the repository at this point in the history
  2. Remove BraveVpnService and BraveVpnWireguardService from services

    This code runs when mini-installer executes for system level installs.
    The install worker is executed for new users but also runs on each upgrade.
    
    This is the first part of the fix, helping solve brave/brave-browser#33726
    
    The second part of the fix will be to install the services when needed (and is a bit tricky).
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    93d7b50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40e87b2 View commit details
    Browse the repository at this point in the history
  4. Updated interface IDs for all items in elevation_service_idl.idl

    This also created a new interface for Development (not in upstream)
    
    This service is not used by Brave currently, but it's in use by Chrome.
    We don't want to have conflicts with the IDs.
    
    Updated IID for elevation service in registration (in install_static)
    
    Updates service naming logic to take channel into account
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6881bb5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    19e5811 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    547e0d9 View commit details
    Browse the repository at this point in the history
  7. Add InstallVPNServices method

    NOTE: this is only used on system installs
    
    This method will check for Brave VPN services and if they are not
    present it will install them. This will only happen if the person
    is a Brave VPN customer and has credentials.
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e628446 View commit details
    Browse the repository at this point in the history
  8. Replace MIDL files before build

    Moves the IDL file into chromium_src, patches BUILD.gn to use
    chromium_src override. IDL output rebuilt at `./src` directory
    using `python3 ./tools/win/update_idl.py`
    
    Using #109 as a guide
    
    Also includes `.gitattributes` fix which prevents differences found
    w/ filecmp.cmpfiles in MIDL compilation.
    simonhong authored and bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    06952fd View commit details
    Browse the repository at this point in the history
  9. Check in MIDL files

    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    05b217e View commit details
    Browse the repository at this point in the history
  10. Move brave_vpn_helper install methods to brave/installer/win/util/

    An attempt to clean up layer violations
    
    Also includes update to `GetVpnHelperServiceProfileDir`
    (`brave_vpn_helper_utils.cc`) to use std::wstring to avoid additional
    base::UTF8ToWide call.
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    baca65b View commit details
    Browse the repository at this point in the history
  11. Cleanup elevation service integration

    - Deleted elevator patch files
    - Deleted chrome/elevation_service deps from components
    - Updated elevation_service BUILD.gn patches
    simonhong authored and bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    9398c34 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7d5d7c0 View commit details
    Browse the repository at this point in the history
  13. Move InstallSystemServices to BraveVPNOSConnectionAPI and throttle

    This will only allow for one call at a time AND will only allow for one
    successful run per browser-open. Subsequent calls to
    `InstallSystemServices` will no-op.
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2285e61 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0bba08a View commit details
    Browse the repository at this point in the history
  15. Fixed pathing issues

    Paths were differing depending on if called from elevation_service.exe
    or brave.exe. There was also logic with official build. This simplifies
    it all.
    
    Tested install does the removal and that buying VPN installs the
    services
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    128fc40 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    942d0fd View commit details
    Browse the repository at this point in the history
  17. Rename IsWireguardServiceRegistered to IsWireguardServiceInstalled

    Matches the `*Installed` check used by VPN helper service
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    88826bc View commit details
    Browse the repository at this point in the history
  18. Move service installation method into brave/browser

    Method is now passed in when connection object is created in browser
    process.
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7d1d7bb View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    389d2ec View commit details
    Browse the repository at this point in the history
  20. Fixed build failures

    simonhong authored and bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b299eb0 View commit details
    Browse the repository at this point in the history
  21. Move VPN service installation over to elevation service

    Updates code to use that code too (removing from the service).
    
    This also removes installation that could happen on brave://settings/system
    This settings install use-case is obsolete now because the services will be
    installed once VPN is actually in use.
    
    This use-case would only happen if the person had VPN but it was set to
    IKEv2 and they did not have the services installed. For example, a user
    install (not a system install).
    bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ae5f61f View commit details
    Browse the repository at this point in the history
  22. Handling connect request while system service installing in-progress

    When system service installing is in-progress, wait till it's completed
    and connect again.
    simonhong authored and bsclifton committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4ed091a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    29290d1 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    ce8bb65 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. cleanup

    bridiver committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    27801b8 View commit details
    Browse the repository at this point in the history
  2. lint

    bridiver committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6ef9ef2 View commit details
    Browse the repository at this point in the history
  3. clang format

    bridiver committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    5eec327 View commit details
    Browse the repository at this point in the history
  4. clean up libs

    bridiver committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1e500ff View commit details
    Browse the repository at this point in the history