Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error about wrong time on sync init #2076

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Show error about wrong time on sync init #2076

merged 2 commits into from
Apr 3, 2019

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Mar 26, 2019 •
edited
Loading

Submitter Checklist:

Fixes brave/brave-browser#3962.

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Adjust computer time 20 minutes forward.
  2. Create a sync chain
  3. Should see:You might be having wrong system time or timezone setup on your device. Please setup the correct time and timezone

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@AlexeyBarabash AlexeyBarabash self-assigned this Mar 26, 2019
@AlexeyBarabash AlexeyBarabash mentioned this pull request Mar 26, 2019
Merged
@AlexeyBarabash AlexeyBarabash force-pushed the sync_show_wrong_time_info branch 3 times, most recently from 77d801d to e309b5b Compare March 29, 2019 21:11
@AlexeyBarabash
Copy link
Contributor Author

Linked brave-sync PR brave/sync#290 .

@AlexeyBarabash AlexeyBarabash force-pushed the sync_show_wrong_time_info branch 2 times, most recently from 1259a9e to 74243f5 Compare April 1, 2019 20:38
@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review April 1, 2019 20:38
@AlexeyBarabash AlexeyBarabash force-pushed the sync_show_wrong_time_info branch from 74243f5 to 81ed149 Compare April 2, 2019 07:52
@AlexeyBarabash
Copy link
Contributor Author

CI build succeeded on Windows and Linux, and failed on MacOS with an error of applying patches.

cezaraugusto
cezaraugusto approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. good one!

@AlexeyBarabash AlexeyBarabash merged commit 2ea169e into master Apr 3, 2019
brave-builds pushed a commit that referenced this pull request Apr 3, 2019
@brave-browser-releases
Uplift of #2076 (squashed) to dev
993ac03
@brave-builds brave-builds mentioned this pull request Apr 3, 2019
Closed
@bsclifton bsclifton deleted the sync_show_wrong_time_info branch April 3, 2019 21:40
@bsclifton bsclifton added this to the 0.65.x - Nightly milestone Apr 3, 2019
@AlexeyBarabash AlexeyBarabash mentioned this pull request Apr 4, 2019
Closed
@bbondy
Copy link
Member

bbondy commented Apr 4, 2019

Hey guys, for text changes let's please include someone from #product for review. Thanks!

@bbondy
Copy link
Member

bbondy commented Apr 4, 2019

This will need some adjusting please, please check with the product team to get the wording.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2019

Created brave/brave-browser#4011 to clean up the text 👍

AlexeyBarabash pushed a commit that referenced this pull request Apr 11, 2019
@brave-browser-releases @AlexeyBarabash
Uplift of #2076 (squashed) to dev
625818b
AlexeyBarabash added a commit that referenced this pull request Apr 11, 2019
@AlexeyBarabash
Merge pull request #2076 from brave/sync_show_wrong_time_info
c397736 
Show error about wrong time on sync init
AlexeyBarabash pushed a commit that referenced this pull request Apr 19, 2019
@brave-browser-releases @AlexeyBarabash
Uplift of #2076 (squashed) to beta
daaabca
@AlexeyBarabash AlexeyBarabash mentioned this pull request Apr 19, 2019
Closed
AlexeyBarabash added a commit that referenced this pull request Apr 19, 2019
@AlexeyBarabash
Merge pull request #2076 from brave/sync_show_wrong_time_info
955e8ed 
Show error about wrong time on sync init
@LaurenWags LaurenWags mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@bbondy bbondy Awaiting requested review from bbondy

@darkdh darkdh Awaiting requested review from darkdh

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
enhancement feature/sync
Projects
Sync - All platforms
Archived in project
Milestone
0.65.x - Release
Development

Successfully merging this pull request may close these issues.

Sync: proper message on wrong device time
5 participants
@AlexeyBarabash @bbondy @kjozwiak @cezaraugusto @bsclifton