Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Re-add call to prepare keyed service factories #20832

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

kylehickinson
Copy link
Collaborator

This used to be in our custom startup logic, but with that gone we can just place it in the chromium_src override we already have

Follow up to #20598

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Nov 3, 2023
@kylehickinson kylehickinson self-assigned this Nov 3, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner November 3, 2023 14:41
This used to be in our custom startup logic, but with that gone we can just place it in the chromium_src override we already have
@kylehickinson kylehickinson force-pushed the ios-ensure-keyed-services-fix branch from 87104de to c0444ce Compare November 3, 2023 14:42
@kylehickinson kylehickinson merged commit 60ec436 into master Nov 3, 2023
@kylehickinson kylehickinson deleted the ios-ensure-keyed-services-fix branch November 3, 2023 15:31
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Nov 3, 2023
brave-builds added a commit that referenced this pull request Nov 3, 2023
kjozwiak pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants