Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nightly can set as a default browser on MacOS #2107

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 28, 2019

Fix brave/brave-browser#3817

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

yarn test brave_browser_tests --filter=BraveShellIntegrationTest.*

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong added this to the 0.64.x - Nightly milestone Mar 28, 2019
@simonhong simonhong self-assigned this Mar 28, 2019
@simonhong simonhong requested a review from darkdh March 28, 2019 06:50
@simonhong simonhong merged commit 9908a5d into master Mar 28, 2019
@simonhong simonhong deleted the make_canary_as_default_on_mac branch March 28, 2019 22:13
@bsclifton
Copy link
Member

@simonhong can you please add a test plan to brave/brave-browser#3817? 😄

@simonhong
Copy link
Member Author

@bsclifton done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"This is a secondary installation of Brave, and cannot be made your default browser."
3 participants