Fixed tab crash when tab is closed from context menu

[simonhong]

fix brave/brave-browser#34909

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Note: I only can repro this crash with below steps on macOS.

1. Create many tabs and activate right most tab
2. Open right most tab's context menu and click Close other tabs
3. Then, cmd + ,

[sangwoo108]

LGTM

[sangwoo108]

How about resetting context_menu_contents_ in BraveBrowserTabStripController` with this callback?

[simonhong]

Good suggestion! I'll try to refactor in that way after PTO.

[kjozwiak]

Verification PASSED on macOS 14.2 x64 Sonoma using the following build(s):

Brave | 1.63.54 Chromium: 120.0.6099.115 (Official Build) nightly (x86_64)
--- | ---
Revision | 469dad9601622e55936a6f4f9cb29e5f83681b1c
OS | macOS Version 14.2 (Build 23C64)

Reproduced the original issue using 1.63.45 Chromium: 120.0.6099.115 by following the STR/Cases outlined via #21397 (comment). Browser crashes as per 858d0d00-100a-300b-0000-000000000000.

Verified that the crash doesn't occur once 1.63.54 Chromium: 120.0.6099.115 was installed by following the STR/Cases outlined via #21397 (comment).