Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ad notifications received" should show Ads viewed between the 1st of the month and the 4th of the following month 0.64.x #2144

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 2, 2019

Uplift for #2132
Fixes brave/brave-browser#3958

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR. I can confirm the errors are not related to any files which were changed for this PR
  • You have tested your change on Nightly.
  • The PR milestones match the branch they're landing to.

… the month and the 4th of the following month
@tmancey tmancey added this to the 0.64.x - Dev milestone Apr 2, 2019
@tmancey tmancey self-assigned this Apr 2, 2019
@tmancey tmancey requested a review from a team April 2, 2019 16:32
@tmancey tmancey changed the title "Ad notifications received" should show Ads viewed between the 1st of the month and the 4th of the following month "Ad notifications received" should show Ads viewed between the 1st of the month and the 4th of the following month 0.64.x Apr 2, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.64.x approved after the required checks have been completed as per the update to the description. Deliberated with @rebron 👍

Please make sure that all the appropriate labels are used and that the appropriate issue is moved into the correct milestone.

@tmancey tmancey merged commit 01c7333 into 0.64.x Apr 2, 2019
@tmancey tmancey deleted the issues/3958-0.64.x branch April 2, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants