Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Twitter tips #2195

Merged
merged 37 commits into from
May 23, 2019
Merged

Add support for Twitter tips #2195

merged 37 commits into from
May 23, 2019

Commits on May 23, 2019

  1. Add Rewards tip icon to all tweets via content script

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    8527f20 View commit details
    Browse the repository at this point in the history

  2. Show tipping banner when user clicks Tip button on a tweet

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    7e5687b View commit details
    Browse the repository at this point in the history

  3. Refactor donations dialog to take a dictionary of parameters

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    29385bc View commit details
    Browse the repository at this point in the history

  4. Add DonateToTwitterUser component and small refactor to accomodate it

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    149ac70 View commit details
    Browse the repository at this point in the history

  5. Add SaveTwitterPublisherInfo and call when displaying twitter tip dialog

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    95bafd6 View commit details
    Browse the repository at this point in the history

  6. Moves logic into native ledger

    @NejcZdovc @emerick
    NejcZdovc authored and emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    e8d5a42 View commit details
    Browse the repository at this point in the history

  7. Add tweetId to TweetMetaData and pass it to donate dialog

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f8c05a0 View commit details
    Browse the repository at this point in the history

  8. Allow retweeting tip

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    35acf1e View commit details
    Browse the repository at this point in the history

  9. Include style info directly in content script

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    a5db4df View commit details
    Browse the repository at this point in the history

  10. Pass tweet metadata to SiteBanner

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    3daca99 View commit details
    Browse the repository at this point in the history

  11. Add timestamp to TweetMetaData and refactor passing of data

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    22dc33f View commit details
    Browse the repository at this point in the history

  12. Add TweetBox component

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    730bfa2 View commit details
    Browse the repository at this point in the history

  13. Remove isTwitterAccount

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    c9376d6 View commit details
    Browse the repository at this point in the history

  14. Use innerText to get tweet content, get timestamp in seconds

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    02734ae View commit details
    Browse the repository at this point in the history

  15. Pass screenName and other metadata to SiteBanner component

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    a7a71aa View commit details
    Browse the repository at this point in the history

  16. Update brave-ui DEPS to point to twitter-tips branch (temporary)

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    ffca9a1 View commit details
    Browse the repository at this point in the history

  17. Adds twitter setting

    @NejcZdovc @emerick
    NejcZdovc authored and emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    b44b276 View commit details
    Browse the repository at this point in the history

  18. Donation -> Tip

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    3095dfc View commit details
    Browse the repository at this point in the history

  19. Move TweetBox component to brave-ui

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    c67d795 View commit details
    Browse the repository at this point in the history

  20. Ensure intent_url is valid before using it

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    0a4467e View commit details
    Browse the repository at this point in the history

  21. Don't include incognito info when getting tab

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f22a434 View commit details
    Browse the repository at this point in the history

  22. Add callback to save visit

    @NejcZdovc @emerick
    NejcZdovc authored and emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    8d18c41 View commit details
    Browse the repository at this point in the history

  23. Add new elements to shadow DOM

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    977f3f7 View commit details
    Browse the repository at this point in the history

  24. Correctly handle Twitter-based publishers

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    42685d6 View commit details
    Browse the repository at this point in the history

  25. Handle second visit correctly

    @NejcZdovc @emerick
    NejcZdovc authored and emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    80c7ecc View commit details
    Browse the repository at this point in the history

  26. Account for refactoring of PublisherInfo data type

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    4247d10 View commit details
    Browse the repository at this point in the history

  27. Incorporate review feedback

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    faaa32a View commit details
    Browse the repository at this point in the history

  28. Allow tweeting any tip

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    100220c View commit details
    Browse the repository at this point in the history

  29. Add browser tests for Twitter tips

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    7df2a0b View commit details
    Browse the repository at this point in the history

  30. Fixes settings button being visible when rewards is off

    @NejcZdovc @emerick
    NejcZdovc authored and emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f592ec2 View commit details
    Browse the repository at this point in the history

  31. Do not show tweet out button for recurring

    @NejcZdovc @emerick
    NejcZdovc authored and emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    d3efb22 View commit details
    Browse the repository at this point in the history

  32. Make timeout optional in TransientTipOverlay component

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    e0cf857 View commit details
    Browse the repository at this point in the history

  33. Move GetTwitterShareURL into ledger

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    e3b6501 View commit details
    Browse the repository at this point in the history

  34. Fix wording of Tweet button

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f68b76b View commit details
    Browse the repository at this point in the history

  35. Move Twitter content script and make naming more Twitter-specific

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    fce01cc View commit details
    Browse the repository at this point in the history

  36. Avoid potential problems with timer and visibilitychange

    @emerick
    emerick committed May 23, 2019
    Configuration menu
    Copy the full SHA
    95e9eab View commit details
    Browse the repository at this point in the history

  37. Add button tooltip and hover state

    @emerick @NejcZdovc
    emerick authored and NejcZdovc committed May 23, 2019
    Configuration menu
    Copy the full SHA
    09729d5 View commit details
    Browse the repository at this point in the history