Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix Leo bugs found in QA iteration 1 #22517

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Mar 8, 2024

Summary

  • Fix popover not showing correctly after tapping on `Advanced Settings
  • Fix popover not showing correctly when tapping the info icon while the keyboard is on screen
  • Update strings to lower-case by default (upper-cased in code)
  • Allow QA to be redirected to the release page to manage subscriptions on a release sandboxed build

Resolves brave/brave-browser#36650
Resolves brave/brave-browser#36653
Resolves brave/brave-browser#36656
Resolves brave/brave-browser#36659

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 8, 2024
@Brandon-T Brandon-T added this to the 1.65.x - Nightly milestone Mar 8, 2024
@Brandon-T Brandon-T self-assigned this Mar 8, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 8, 2024 19:44
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-Bugs branch from ae4bb7c to 19de386 Compare March 8, 2024 20:37
@Brandon-T Brandon-T enabled auto-merge (squash) March 8, 2024 20:45
@Brandon-T Brandon-T disabled auto-merge March 8, 2024 21:25
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-Bugs branch 3 times, most recently from 1f211ec to bb053ee Compare March 11, 2024 16:46
@kylehickinson kylehickinson self-requested a review March 11, 2024 18:16
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-Bugs branch 2 times, most recently from df95efa to 84872f2 Compare March 11, 2024 19:01
… (keyboard, other controller, etc).

Update strings to be lowercased localized and uppercased in code.
Allow QA to test production links on a release channel.

Fix premium subscription info discrepancy.
The AppStore says the user is subscribed, but Leo says they are not.
We only allow the user to MANUALLY activate premium so this causes a bug.

Signed-off-by: Brandon <JustBrandonT@gmail.com>
…cally

Signed-off-by: Brandon <JustBrandonT@gmail.com>
Signed-off-by: Brandon <JustBrandonT@gmail.com>
Signed-off-by: Brandon <JustBrandonT@gmail.com>
Signed-off-by: Brandon <JustBrandonT@gmail.com>
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-Bugs branch from 84872f2 to 1f4e834 Compare March 11, 2024 20:46
@Brandon-T Brandon-T merged commit 18f943b into master Mar 11, 2024
19 checks passed
@Brandon-T Brandon-T deleted the bugfix/Leo-iOS-Bugs branch March 11, 2024 21:38
@hffvld
Copy link
Collaborator

hffvld commented Mar 12, 2024

Verified #36650 on iPhone 14using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.65 (77)
BraveCore: 1.65.77 (123.0.6312.29)

Tooltip pop-up

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Bring up the keyboard
  4. Tap on the Info icon > Verify

ACTUAL RESULTS:

  • Verified that the Info pop-up message is shown in a proper location when the keyboard was previously opened

2024-03-12_10-04-41.mp4
Leo's main menu self opening

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Tap Main menu > Change the language model
  4. Submit query > Verify

ACTUAL RESULTS:

  • Verified that Leo's Main menu is not opened by itself

2024-03-12_10-09-31.mp4
Leo's main menu responsiveness

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Tap Main menu > Advanced Settings
  4. Close Advanced Settings
  5. Tap ⚙️ icon to open Main menu > Verify

ACTUAL RESULTS:

  • Verified that the Main menu can be reopened again at any time

2024-03-12_10-25-28.mp4

@Uni-verse
Copy link
Contributor

Verified brave/brave-browser#36653 using iPhone 12 running iOS 17.3.1 using version 1.65 (77) Nightly channel

  • Ensured that premium is enabled using active credentials
  • Ensured that Manage Subscriptions sends user to account.bravesoftware.com for Nightly channel
RPReplay_Final1710263923.MP4

@hffvld
Copy link
Collaborator

hffvld commented Mar 12, 2024

Verified #36659 on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.4
Brave build: 1.65 (77)
BraveCore: 1.65.77 (123.0.6312.29)

STEPS:

  1. Followed the steps from [Leo] Regenerate function is working only towards the last query brave-browser#36659 (comment)
  2. Verified

ACTUAL RESULTS:

  • Verified that the Regenerate function works towards each query in the chat.

2024-03-12_10-39-58.mp4

@Uni-verse
Copy link
Contributor

Verified brave/brave-browser#36656 using Nightly channel version 1.65 (77) on iPhone 12 running iOS 17.3.1

Example Example
IMG_1319 IMG_1320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
4 participants