-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] - Fix Leo bugs found in QA iteration 1 #22517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
added
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
labels
Mar 8, 2024
ios/brave-ios/Sources/AIChat/Subscription/SDK/BraveStoreSDK.swift
Outdated
Show resolved
Hide resolved
Brandon-T
force-pushed
the
bugfix/Leo-iOS-Bugs
branch
from
March 8, 2024 20:37
ae4bb7c
to
19de386
Compare
kylehickinson
approved these changes
Mar 8, 2024
This was referenced Mar 8, 2024
Brandon-T
force-pushed
the
bugfix/Leo-iOS-Bugs
branch
3 times, most recently
from
March 11, 2024 16:46
1f211ec
to
bb053ee
Compare
Brandon-T
force-pushed
the
bugfix/Leo-iOS-Bugs
branch
2 times, most recently
from
March 11, 2024 19:01
df95efa
to
84872f2
Compare
… (keyboard, other controller, etc). Update strings to be lowercased localized and uppercased in code. Allow QA to test production links on a release channel. Fix premium subscription info discrepancy. The AppStore says the user is subscribed, but Leo says they are not. We only allow the user to MANUALLY activate premium so this causes a bug. Signed-off-by: Brandon <JustBrandonT@gmail.com>
…cally Signed-off-by: Brandon <JustBrandonT@gmail.com>
Signed-off-by: Brandon <JustBrandonT@gmail.com>
Signed-off-by: Brandon <JustBrandonT@gmail.com>
Signed-off-by: Brandon <JustBrandonT@gmail.com>
Brandon-T
force-pushed
the
bugfix/Leo-iOS-Bugs
branch
from
March 11, 2024 20:46
84872f2
to
1f4e834
Compare
kylehickinson
approved these changes
Mar 11, 2024
Verified #36650 on
Tooltip pop-upSTEPS:
ACTUAL RESULTS:
2024-03-12_10-04-41.mp4Leo's main menu self openingSTEPS:
ACTUAL RESULTS:
2024-03-12_10-09-31.mp4Leo's main menu responsivenessSTEPS:
ACTUAL RESULTS:
2024-03-12_10-25-28.mp4 |
Verified brave/brave-browser#36653 using
RPReplay_Final1710263923.MP4 |
Verified #36659 on
STEPS:
ACTUAL RESULTS:
2024-03-12_10-39-58.mp4 |
Verified brave/brave-browser#36656 using Nightly channel version
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-android
Do not run CI builds for Android
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
info
icon while the keyboard is on screenResolves brave/brave-browser#36650
Resolves brave/brave-browser#36653
Resolves brave/brave-browser#36656
Resolves brave/brave-browser#36659
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: