Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nebula support for P3A/Constellation #22522

Merged
merged 10 commits into from
Jun 21, 2024
Merged

Add Nebula support for P3A/Constellation #22522

merged 10 commits into from
Jun 21, 2024

Commits on Jun 21, 2024

  1. WIP: stub out differential privacy sampling

    @rillian @DJAndries
    rillian authored and DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    06bbeff View commit details
    Browse the repository at this point in the history

  2. Add Nebula support for P3A/Constellation

    @DJAndries
    DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    24fd8e1 View commit details
    Browse the repository at this point in the history

  3. Nebula bug fixes & unit test fixes

    @DJAndries
    DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6011bb9 View commit details
    Browse the repository at this point in the history

  4. Add tests for Nebula

    @DJAndries
    DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9d5beec View commit details
    Browse the repository at this point in the history

  5. Correct Nebula participation/scramble function

    @DJAndries
    DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    3c94ccb View commit details
    Browse the repository at this point in the history

  6. Add documentation comments for Nebula constants 

    Describe where the new constants come from and link to the original
issue which describes the protocol design.
    @rillian @DJAndries
    rillian authored and DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    69d54d7 View commit details
    Browse the repository at this point in the history

  7. P3A: Mark locals const 

    Use `const` annotations for local variables that don't need
multiple assignment to make the flow contract more obvious.

Addresses a review comment.
    @rillian @DJAndries
    rillian authored and DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    01ad05f View commit details
    Browse the repository at this point in the history

  8. P3A: add CHECK protections 

    Halt with an assert violation instead of dereferencing a null.

Addressses a review comment.
    @rillian @DJAndries
    rillian authored and DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    79eb9c9 View commit details
    Browse the repository at this point in the history

  9. P3A: Rename Nebula scramble function 

    This really does two things, which I've tried to make more clear
with a comment, but `MaybeFoo` is a more common idiom in our code,
and it avoids the misleading idea that scrambling happens most of
the time.
    @rillian @DJAndries
    rillian authored and DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    15e84d2 View commit details
    Browse the repository at this point in the history

  10. P3A: Don't prepare non-participating Nebula messages 

    Return early after discarding Histograms which won't be submitted
so we don't waste time trying to process them further.
    @rillian @DJAndries
    rillian authored and DJAndries committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    dd166a1 View commit details
    Browse the repository at this point in the history