Make proper native theme observer gets native theme change noti (uplift to 0.64.x) #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
simonhong
force-pushed
the
pr2219_align_windows_os_theme_with_brave_theme_0.64.x
branch
from
d7b8e02 to
e185831
Compare
kjozwiak
reviewed
May 7, 2019
There was a problem hiding this comment.
Uplift to 0.64.x denied after deliberating with @rebron. It's a bit too late for 0.64.x as we're planning on releasing next Tuesday which doesn't give us a lot of time. At this point, we should only be uplifting important fixes/regressions as we're so close to a release.
@bsclifton rebased #2331 (comment). Once that looks good, we can get that uplifted into 0.65.x.
@simonhong please let me know if you disagree with the above 👍
simonhong
deleted the
pr2219_align_windows_os_theme_with_brave_theme_0.64.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #2219
Issue: brave/brave-browser#4059