-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes date from ads grants in the wallet #2337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
claimed-grant-date
branch
2 times, most recently
from
April 25, 2019 06:53
344442d
to
bafe446
Compare
NejcZdovc
force-pushed
the
claimed-grant-date
branch
from
April 25, 2019 06:56
bafe446
to
ac4d3c9
Compare
tmancey
previously approved these changes
Apr 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but does have test failures so please check these
@tmancey are you talking about |
ryanml
previously approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
straightforward, lgtm
NejcZdovc
force-pushed
the
claimed-grant-date
branch
from
April 26, 2019 06:12
ac4d3c9
to
225cbf8
Compare
NejcZdovc
force-pushed
the
claimed-grant-date
branch
from
April 26, 2019 06:21
225cbf8
to
c3f2ea0
Compare
ryanml
approved these changes
Apr 26, 2019
NejcZdovc
added a commit
that referenced
this pull request
May 3, 2019
Removes date from ads grants in the wallet
NejcZdovc
added a commit
that referenced
this pull request
May 3, 2019
Removes date from ads grants in the wallet
NejcZdovc
added a commit
that referenced
this pull request
May 3, 2019
Removes date from ads grants in the wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#4169
UI PR: brave/brave-ui#458
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.