Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade patches from Chromium "74.0.3729.108" to Chromium 74.0.3729.131 #2353

Merged
merged 2 commits into from
May 2, 2019
Merged

Upgrade patches from Chromium "74.0.3729.108" to Chromium 74.0.3729.131 #2353

merged 2 commits into from
May 2, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 1, 2019 •
edited
Loading

@bsclifton bsclifton added this to the 0.66.x - Nightly milestone May 1, 2019
@bsclifton bsclifton requested review from emerick and mkarolin May 1, 2019 14:03
@bsclifton bsclifton self-assigned this May 1, 2019
bsclifton
bsclifton commented May 1, 2019
View reviewed changes
patches/components-search_engines-prepopulated_engines.json.patch Outdated
"suggest_url": "https://api.qwant.com/api/suggest/?q={searchTerms}&client=opensearch",
"type": "SEARCH_ENGINE_QWANT",
"id": 94
+=======
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops - gotta fix this

emerick
emerick approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkarolin
mkarolin approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member Author

Build finishes and test pass - test-security is failing for an unrelated issue. Should be good to go! 👍

@bsclifton bsclifton merged commit c9aaa3a into master May 2, 2019
@bsclifton bsclifton deleted the 74.0.3729.131_master_22 branch May 2, 2019 17:36
This was referenced May 2, 2019
Merged
Merged
bsclifton added a commit that referenced this pull request May 2, 2019
@bsclifton
Merge pull request #2353 from brave/74.0.3729.131_master_22
2229ebc 
Upgrade patches from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
bsclifton added a commit that referenced this pull request May 2, 2019
@bsclifton
Merge pull request #2353 from brave/74.0.3729.131_master_22
ba98cb6 
Upgrade patches from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
This was referenced May 2, 2019
Merged
Merged
@bsclifton bsclifton mentioned this pull request May 3, 2019
Merged
bsclifton added a commit that referenced this pull request May 3, 2019
@bsclifton
Merge pull request #2353 from brave/74.0.3729.131_master_22
282b7a6 
Upgrade patches from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #2353 from brave/71.0.3578.80
6ee247c 
Upgrade from 71.0.3578.75 to 71.0.3578.80
@MarkBuffalo MarkBuffalo mentioned this pull request Apr 19, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Apr 19, 2024
Open
@CxsLucyfer CxsLucyfer mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@emerick emerick emerick approved these changes

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.66.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 74.0.3729.108 to 74.0.3729.131
4 participants
@bsclifton @emerick @mkarolin @brave-browser-releases