Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strings for NavigationBar on relevant WebUI data sources directly #2384

Merged
merged 1 commit into from
May 13, 2019
Merged

Add strings for NavigationBar on relevant WebUI data sources directly #2384

merged 1 commit into from
May 13, 2019

Commits on May 9, 2019

  1. Add strings for NavigationBar on relevant WebUI data sources directly. 

    This fixes a layer-violation for dependencies where we were using a convenience function in the base //ui project in order to set the strings on all WebUI data sources. With this refactor, the dependencies are already in place from the chromium ui project (containing the webui data sources) to the brave webui project (containing the new navigation bar data provider).

This new NavigationBarDataProvider is not much of a class, in that it only contains a single static function, but it follows the chromium practice of splitting data in to functional classes, and leaving it up to the provider as to whether it adds strings, functions or observers to the WebUI.
    @petemill
    petemill committed May 9, 2019
    Configuration menu
    Copy the full SHA
    f37ff3f View commit details
    Browse the repository at this point in the history