replaced a if check by assert statement

[ajayseeker]

Resolves brave/brave-browser#29918

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[ajayseeker]

Hi @sangwoo108!
Created this PR, I replaced the if statement with assert, build ran fine and browser too launched without any glitch. I guess we now need to check if all tests pass with this change to be sure that this isn't breaking, right?

[sangwoo108]

Please move this into deps = [] above. We don't need to add this with +=.

[ajayseeker]

Done!

[sangwoo108]

Hi @sangwoo108! Created this PR, I replaced the if statement with assert, build ran fine and browser too launched without any glitch. I guess we now need to check if all tests pass with this change to be sure that this isn't breaking, right?

That's right. I'm going to run CI 😄

[sangwoo108]

CI complains about the formatting. Please run npm run format

[ajayseeker]

CI complains about the formatting. Please run npm run format

oh sorry! should have taken care of this.
I ran npm run format and checked-in change. Can we run CI once again?
@sangwoo108

[ajayseeker]

Security check seems to fail, but looking at the error

securityUnhandled error: HttpError: Resource not accessible by integration
Unhandled error: HttpError: Resource not accessible by integration

it doesn't seem related. @sangwoo108, what went wrong?

[sangwoo108]

Yeah, looks weird. Asking other folks.

[ajayseeker]

Yeah, looks weird. Asking other folks.

Hey! the tests passed, I guess we just need someone to review it and then it can be merged.

[sangwoo108]

LGTM! Thanks for the patch