Add Nebula support for P3A/Constellation (uplift to 1.68) #24329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe where the new constants come from and link to the original issue which describes the protocol design.
Use `const` annotations for local variables that don't need multiple assignment to make the flow contract more obvious. Addresses a review comment.
Halt with an assert violation instead of dereferencing a null. Addressses a review comment.
This really does two things, which I've tried to make more clear with a comment, but `MaybeFoo` is a more common idiom in our code, and it avoids the misleading idea that scrambling happens most of the time.
Return early after discarding Histograms which won't be submitted so we don't waste time trying to process them further.
kjozwiak
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Uplift into 1.68.x approved 👍 QA has verified the PR on Nightly using 1.69.x as per #22522 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#35841
Uplift of #22522
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: