Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Split view UI #24385

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Polish Split view UI #24385

merged 1 commit into from
Jun 26, 2024

Conversation

sangwoo108
Copy link
Contributor

  • Update border style: thickness and color
  • Remove hovered effect on menu items
  • Set vertical margin around menu bubble

part of brave/brave-browser#39027

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

* Update border style: thickness and color
* Remove hovered effect on menu items
* Set vertical margin around menu bubble
@sangwoo108 sangwoo108 merged commit 3cc8fa3 into master Jun 26, 2024
20 checks passed
@sangwoo108 sangwoo108 deleted the sko/split-view-polish branch June 26, 2024 23:07
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants