Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BookmarkBar] Remove vertical line separator when "Show All Bookmarks" is unchecked in Bookmark bar. #24390

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jagadeshjai
Copy link
Collaborator

  • Update the visibility of line separator in Bookmarks bar when "Show All Bookmarks" is unchecked.

Resolves brave/brave-browser#36554

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@jagadeshjai
Copy link
Collaborator Author

@sangwoo108 Please take a look.

@sangwoo108 sangwoo108 self-requested a review June 26, 2024 23:42
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sangwoo108 sangwoo108 merged commit cee5796 into brave:master Jun 27, 2024
19 checks passed
@rebron rebron added this to the 1.69.x - Nightly milestone Jul 16, 2024
simonhong pushed a commit that referenced this pull request Jul 17, 2024
[BookmarkBar] Remove vertical line separator when "Show All Bookmarks" is unchecked in Bookmark bar.
@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2024

Verified with

Brave | 1.69.115 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit)
-- | --
Revision | 0f3c95cf9cac0acfd6d49bd72bb2ed548901a082
OS | Linux

Verified STR from brave/brave-browser#36554 (comment).
Confirmed vertical line separator does not re-appear on browser restart as per STR.
Checked using both light and dark themes.

Light Dark
Screenshot 2024-07-17 at 2 19 08 PM Screenshot 2024-07-17 at 2 19 41 PM

kjozwiak pushed a commit that referenced this pull request Jul 17, 2024
* Uplift of #24694 (squashed) to beta

* Merge pull request #24390 from jagadeshjai/fix__bookmar_bar_separator

[BookmarkBar] Remove vertical line separator when "Show All Bookmarks" is unchecked in Bookmark bar.

---------

Co-authored-by: Sangwoo Ko <sko@brave.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vertical line separator on Bookmarks Toolbar re-appears after browser relaunch - follow up to #6043
4 participants