[ads] General code health

[tmancey]

Resolves brave/brave-browser#39403

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Regression test for search result ads.

[diracdeltas]

ok to ignore the security action findings as long as these are all refactoring changes, not adding any new code

[github-actions]

[puLL-Merge] - brave/brave-core@24397

Description

This PR refactors the handling of search result ads in Brave, renaming components and restructuring the code to improve organization and clarity. The main changes involve renaming "SearchResultAd" to "CreativeSearchResultAd" and moving files to a new "creatives" directory structure. The PR also includes updates to related tests and changes to the mojom interface.

Changes

Changes

1. browser/brave_ads/BUILD.gn:

   • Updated file paths and names to reflect the new structure

2. browser/brave_ads/creatives/search_result_ad/:

   • Added new files for handling creative search result ads
   • Implemented CreativeSearchResultAdTabHelper to replace SearchResultAdTabHelper
   • Added new test files and utilities for creative search result ads

3. browser/brave_ads/ad_units/search_result_ad/:

   • Removed old files related to search result ads

4. browser/brave_tab_helpers.cc:

   • Updated to use CreativeSearchResultAdTabHelper instead of SearchResultAdTabHelper

5. components/brave_ads/content/browser/BUILD.gn:

   • Updated file paths and names to reflect the new structure

6. components/brave_ads/content/browser/creatives/search_result_ad/:

   • Added new files for handling creative search result ads
   • Implemented CreativeSearchResultAdHandler to replace SearchResultAdHandler
   • Added new test files and utilities for creative search result ads

7. components/brave_ads/core/mojom/brave_ads.mojom:

   • Renamed ConversionInfo to CreativeSetConversionInfo
   • Updated CreativeSearchResultAdInfo to use CreativeSetConversionInfo

8. ios/brave-ios/Sources/.../BraveSearchResultAdScriptHandler.swift:

   • Updated to use CreativeSetConversionInfo instead of ConversionInfo

9. test/data/brave_ads/:

   • Renamed and updated test HTML files

Possible Issues

• The extensive renaming and restructuring may require updates to any external code or documentation that references the old naming conventions or file structures.
• There's a potential for introducing bugs during such a large refactoring, especially in areas where the logic has been significantly changed or moved.

Security Hotspots

No significant security hotspots were identified in this change. The refactoring primarily focuses on reorganization and renaming, which should not introduce new security vulnerabilities if implemented correctly.