Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Do not classify page content for same document navigations #24568

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 9, 2024

Resolves brave/brave-browser#39506

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

For multi-page navigations, we should classify page content and verify conversions. For single-page (same document. i.e., https://mdn.github.io/dom-examples/history-api/) navigations, we should classify page content in the primary main frame and verify conversions.

@tmancey tmancey self-assigned this Jul 9, 2024
@tmancey tmancey requested a review from a team as a code owner July 9, 2024 16:41
@tmancey tmancey force-pushed the issues/39506 branch 4 times, most recently from cda10da to e8e617d Compare July 9, 2024 18:56
@tmancey tmancey enabled auto-merge July 9, 2024 21:36
@tmancey tmancey closed this Jul 11, 2024
auto-merge was automatically disabled July 11, 2024 13:17

Pull request was closed

@tmancey tmancey reopened this Jul 11, 2024
@tmancey tmancey enabled auto-merge July 11, 2024 13:17
@tmancey tmancey merged commit 5f64c50 into master Jul 11, 2024
27 checks passed
@tmancey tmancey deleted the issues/39506 branch July 11, 2024 17:09
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Do not classify page content for same document navigations
2 participants