Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): do not remove NFT when marked as junk (uplift to 1.69.x) #24793

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(wallet): do not remove NFT when marked as junk (uplift to 1.69.x) #24793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions components/brave_wallet_ui/common/slices/endpoints/token.endpoints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,27 +501,6 @@ export const tokenEndpoints = ({

cache.clearUserTokensRegistry()

const deleteResult = await braveWalletService.removeUserAsset(
arg.token
)

if (!deleteResult.success) {
throw new Error('Unable to delete token')
}

// track token if not spam
if (!arg.isSpam) {
const { success: addTokenSuccess } = await addUserToken({
braveWalletService,
cache,
tokenArg: { ...arg.token, isSpam: arg.isSpam }
})

if (!addTokenSuccess) {
throw new Error('Unable to add token')
}
}

return {
data: success
}
Expand Down
5 changes: 3 additions & 2 deletions components/brave_wallet_ui/components/desktop/views/nfts/components/nfts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,9 +576,10 @@ export const Nfts = ({
})
: renderedListPage.map((nft) => {
const assetId = getAssetIdKey(nft)
const isSpam = allSpamNftsIds.includes(assetId)
const isSpam =
nft.isSpam || allSpamNftsIds.includes(assetId)
const isHidden =
isSpam ||
!nft.visible ||
Boolean(
userTokensRegistry?.nonFungibleHiddenTokenIds.includes(
assetId
Expand Down
Loading