Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves pending contributon into mojom definition #2510

Merged
merged 1 commit into from
May 28, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 28, 2019

Resolves brave/brave-browser#4620

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • tip multiple unverified site
  • make sure that you see pending box in your wallet
  • open dialog
  • try deleting single site
  • try deleting all sites
  • make sure that everything is carried out correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc requested a review from tmancey May 28, 2019 09:45
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 1d9f2b7 into master May 28, 2019
@bsclifton bsclifton deleted the pending-mojo branch June 25, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move pending contributions to mojo interface
2 participants