Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel downloading option android #25157

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 15, 2024

Resolves brave/brave-browser#38772

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added this to the 1.71.x - Nightly milestone Aug 15, 2024
@deeppandya deeppandya self-assigned this Aug 15, 2024
@deeppandya deeppandya requested review from a team as code owners August 15, 2024 21:22
@deeppandya deeppandya force-pushed the parallel_downloading_option_android branch from 7d453a9 to 5e3720e Compare August 15, 2024 21:47
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src, strings++

@deeppandya deeppandya merged commit 4b7b76f into master Aug 18, 2024
21 checks passed
@deeppandya deeppandya deleted the parallel_downloading_option_android branch August 18, 2024 18:37
brave-builds added a commit that referenced this pull request Aug 18, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.71.17 Chromium: 128.0.6613.40 (Official Build) canary (64-bit)
--- | ---
Revision | 72ebb76e3dbd76018bf00f14d10b73ef0d42f0c8
OS | Android 15; Build/AP31.240617.015; 35; REL
  • ensured that Parallel Downloading is enabled by default
  • ensured that Parallel Downloading is being displayed via Settings -> Downloads
  • ensure that you can enable/disable the feature without any issues
    • also ensured that brave://flags#enable-parallel-downloading is displaying the correct state when enabled/disabled
  • ensured that the current state (either enabled/disabled) is maintained after restarting the browser several times
Example Example Example Example
1000002020 1000002024 1000002021 1000002022

Also ensured that the current state of the feature is maintained when updating via the following STR/Cases:

  • downloaded/installed 1.71.15 Chromium: 128.0.6613.40
  • disabled Parallel Downloading and restarted Brave (ensured that Parallel Downloading was disabled)
  • upgraded 1.71.15 Chromium: 128.0.6613.40 --> 1.71.17 Chromium: 128.0.6613.40
  • ensured that Parallel Downloading was still disabled
  • ensured that you can re-enable without any issues/failures
    • checked and ensured that brave://flags#enable-parallel-downloading is enabled

kjozwiak pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Parallel downloading setting
4 participants