Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string in shields android #25204

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 19, 2024

Resolves brave/brave-browser#40279

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Aug 19, 2024
@deeppandya deeppandya added this to the 1.71.x - Nightly milestone Aug 19, 2024
@deeppandya deeppandya self-assigned this Aug 19, 2024
@deeppandya deeppandya requested a review from a team as a code owner August 19, 2024 19:45
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya force-pushed the update_string_in_shields_android branch from c8dcc6e to 68f75cd Compare August 20, 2024 12:05
@deeppandya deeppandya force-pushed the update_string_in_shields_android branch from 68f75cd to 03b91ba Compare August 20, 2024 21:58
@deeppandya deeppandya merged commit 74f16e3 into master Aug 20, 2024
22 checks passed
@deeppandya deeppandya deleted the update_string_in_shields_android branch August 20, 2024 23:04
brave-builds added a commit that referenced this pull request Aug 20, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.71.19 Chromium: 128.0.6613.40 (Official Build) canary (64-bit)
--- | ---
Revision | 5eb3839b80e16795e90d301db60d75fef1333ae3
OS | Android 15; Build/AP31.240617.015; 35; REL

Using the STR/Cases outlined via brave/brave-browser#40279 (comment), ensured that follow you across the web-tracking what you do was changed to follow you across the web, tracking what you do via the shields panel under ? as per the following:

Screenshot_20240821-143358

kjozwiak pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update info text on Shields
3 participants