Disable Greaselion if Rewards is off #25535
Conversation
| @@ -270,6 +270,9 @@ GreaselionServiceImpl::GetExtensionIdsForTesting() { | |||
| } | |||
|
|
|||
| void GreaselionServiceImpl::UpdateInstalledExtensions() { | |||
| if (!delegate_->IsEnabled()) { | |||
| return; | |||
There was a problem hiding this comment.
Will this unload currently installed Greaselion extensions if it's disabled? If not, should it? I'm wondering if this check could go in CreateAndInstallExtensions. @emerick WDYT?
There was a problem hiding this comment.
Nope, it doesn't just to simplify the code.
IMHO it's okay to have the extensions loaded if the users changed Rewards state, since it's a rare case.
The goal is to cover the usual scenarios to improve perf.
There was a problem hiding this comment.
That sounds fine. In that case, the intended behavior here is that GL extensions will not be added or updated if Rewards is disabled. They will remain as-is if Rewards is disabled via reset.
| #include "brave/components/greaselion/browser/greaselion_service.h" | ||
| #include "brave/components/greaselion/browser/greaselion_service_impl.h" | ||
| #include "chrome/browser/extensions/extension_service.h" | ||
| #include "chrome/browser/profiles/profile.h" |
There was a problem hiding this comment.
Can we check if these need deps?
There was a problem hiding this comment.
thanks, updated sources.gni.
Frankly, I don't full understand that approach with "components" in brave/browser/ until chrome does the same.
If fact, we push all the deps into a one list and non on them can be build separately.
atuchin-m
force-pushed
the
disable-greaselion-service-if-rewards-is-off
branch
from
03bfc8d
to
e443e96
Compare
* Disable Greaselion if Rewards is off * update deps
Resolves brave/brave-browser#40872
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
brave/brave-browser#39610 (comment)