-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons]: Remove old icon overrides #25577
Conversation
[puLL-Merge] - brave/brave-core@25577 DescriptionThis PR removes custom Brave icons and replaces them with standard Chrome icons in the settings page. The main changes include:
The motivation for this change appears to be standardizing the icon usage across the settings page, likely to improve maintainability and consistency with the rest of the Chrome UI. ChangesChanges
These changes collectively remove custom Brave icons and replace them with standard Chrome icons throughout the settings page. |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patches
++
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#41086
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: