Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix for safe browsing (uplift to 1.70.x) #25579

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[Android] Fix for safe browsing (uplift to 1.70.x) #25579

merged 1 commit into from
Sep 17, 2024

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Sep 16, 2024 •
edited by kjozwiak
Loading

Uplift of #25562
Resolves brave/brave-browser#41060

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@samartnik
[Android] Fix for safe browsing
dde6569 
This is temporary fix to keep using safetynet for checking urls for safe browsing. We will have to change the way we handle it in C130 due to this change https://source.chromium.org/chromium/chromium/src/+/e5700c49b75254cc1201a3bbea59b20b06328a27
@samartnik samartnik requested a review from a team as a code owner September 16, 2024 13:23
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 16, 2024
@kjozwiak kjozwiak mentioned this pull request Sep 16, 2024
Closed
7 tasks
@kjozwiak kjozwiak added this to the 1.70.x - Release milestone Sep 17, 2024
kjozwiak
kjozwiak approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍 QA has verified the PR on Nightly using 1.71.x as per #25562 (comment).

@kjozwiak kjozwiak merged commit 1a99864 into 1.70.x Sep 17, 2024
14 checks passed
@kjozwiak kjozwiak deleted the pr25562_android_safe_browsing_fix_1.70.x branch September 17, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@samartnik samartnik

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@samartnik @kjozwiak