Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.70.x (Chromium 129) (1.70.x). #25588

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#41009

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Sep 16, 2024
@mkarolin mkarolin requested a review from a team as a code owner September 16, 2024 16:46
@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Sep 16, 2024
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Sep 16, 2024
@kjozwiak kjozwiak added this to the 1.70.x - Release milestone Sep 16, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍

@kjozwiak kjozwiak merged commit fc9254f into 1.70.x Sep 16, 2024
14 of 15 checks passed
@kjozwiak kjozwiak deleted the maxk-1.70.x-release-l10n branch September 16, 2024 20:41
mkarolin added a commit that referenced this pull request Sep 16, 2024
mkarolin added a commit that referenced this pull request Sep 16, 2024
kjozwiak pushed a commit that referenced this pull request Sep 17, 2024
Update l10n for 1.70.x (Chromium 129) (1.70.x). (#25588)

Updated l10n for 1.70.x release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants