Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Provide More Details link from crashes window #2564

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented May 31, 2019

fixes brave/brave-browser#889

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from bbondy May 31, 2019 13:40
@pilgrim-brave pilgrim-brave self-assigned this May 31, 2019
@pilgrim-brave pilgrim-brave added this to the 0.68.x - Nightly milestone May 31, 2019
@pilgrim-brave
Copy link
Contributor Author

QA test plan:

  1. Open a new tab
  2. Visit chrome://crash in a new tab, tab crashes
  3. Visit chrome://crashes in a new tab, ensure crash report is uploaded
  4. If the crash report is not uploaded click send now and restart the browser
  5. Revisit chrome://crashes and verify that there is no "Provide more details" link below the crash report

link.textContent = loadTimeData.getString('bugLinkText');
linkBlock.appendChild(link);
- crashBlock.appendChild(linkBlock);
+ //crashBlock.appendChild(linkBlock); // feature disabled in Brave
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to accomplish this without patching?

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because I can't think of another way that is more clean.

@pilgrim-brave pilgrim-brave merged commit bbafa51 into master Jun 19, 2019
@kjozwiak kjozwiak deleted the mpilgrim_889 branch June 19, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide additional details under crash id tries to open code.google.com
2 participants