Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(privacy): Filter search case sensitivity on iOS #25675

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

StephenHeaps
Copy link
Collaborator

  • We were lowercasing the user-entered search text, but then performing a case-sensitive search on the title & description of the filters.

Resolves brave/brave-browser#41168

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open app Settings -> Brave Shields & Privacy -> Content Filtering
  2. Scroll down slightly to reveal search bar
  3. Enter You as search text
  4. Verify all filters with You are visible
  5. Change search text to YoUtUbE
  6. Verify all filters with YouTube are visible
  7. Change search text to easylist
  8. Verify all filters with EasyList are visible
You YoUtUbE easylist
You YoUtUbE easylist

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Sep 20, 2024
@StephenHeaps StephenHeaps self-assigned this Sep 20, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner September 20, 2024 16:03
@StephenHeaps StephenHeaps enabled auto-merge (squash) September 20, 2024 16:06
@StephenHeaps StephenHeaps changed the title fix(privacy): Filter search case sensitivity fix(privacy): Filter search case sensitivity on iOS Sep 20, 2024
@StephenHeaps StephenHeaps merged commit a8c6459 into master Sep 20, 2024
18 checks passed
@StephenHeaps StephenHeaps deleted the bugfix/filter-search-case-sensitivity branch September 20, 2024 17:19
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 20, 2024
brave-builds added a commit that referenced this pull request Sep 20, 2024
brave-builds added a commit that referenced this pull request Sep 20, 2024
StephenHeaps pushed a commit that referenced this pull request Sep 20, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18 using version 1.72 (49)

Test Plan

  1. Open app Settings -> Brave Shields & Privacy -> Content Filtering
  2. Scroll down slightly to reveal search bar
  3. Enter You as search text
  4. Verify all filters with You are visible
  5. Change search text to YoUtUbE
  6. Verify all filters with YouTube are visible
  7. Change search text to easylist
  8. Verify all filters with EasyList are visible
  • Ensured that filter search is not case sensitive using search bar.
  • Ensured that External Filter Lists as well as Default Filter lists are searchable.
  • Ensured that both filter title and content is searchable.
"youtube" "YoUtUbE" "You" "Ho" (searching title + content) Returning both lists
IMG_7542 IMG_7543 IMG_7544 IMG_7546 IMG_7547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #36036] Filter search not returning correct results
4 participants