Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove check_includes = false from browser/android/preferences #25686

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Sep 21, 2024

Resolves brave/brave-browser#41487

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Sep 22, 2024
@bridiver bridiver force-pushed the android-preferences-check-includes branch from a8f0982 to 0c03ff9 Compare October 6, 2024 20:43
@bridiver bridiver requested review from bsclifton and a team as code owners October 6, 2024 20:43
@bridiver bridiver requested review from a team as code owners October 7, 2024 19:54
@bridiver bridiver requested a review from a team as a code owner October 7, 2024 23:50
@github-actions github-actions bot added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Oct 7, 2024
@bridiver bridiver force-pushed the android-preferences-check-includes branch from 8899736 to 9c9d0b7 Compare October 8, 2024 14:40
@bridiver bridiver merged commit 6775aa1 into master Oct 8, 2024
19 checks passed
@bridiver bridiver deleted the android-preferences-check-includes branch October 8, 2024 17:54
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Oct 8, 2024
@brave-builds
Copy link
Collaborator

Released in v1.72.72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 needs-security-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove check_includes = false from //brave/browser/android/preferences
5 participants