Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new build_policy_templates action #25699

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsclifton
Copy link
Member

Currently, group policy is only generated during create_dist. This allows us to quickly create policy_templates.zip and the Brave specific version brave_policy_templates.zip.

Fixes brave/brave-browser#41217

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Be on Windows
  2. Inside the src/brave folder, run npm run build_policy_templates
  3. Verify src/out/Component/policy_templates.zip and src/out/Component/brave_policy_templates.zip were generated

@bsclifton bsclifton requested a review from a team as a code owner September 23, 2024 19:55
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Sep 23, 2024
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) needs-security-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new build_policy_templates action for generating group policy resources
3 participants