Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set brave search as a default search provider in AU (uplift to 1.71.x) #25899

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Set brave search as a default search provider in AU (uplift to 1.71.x) #25899

merged 1 commit into from
Oct 21, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 9, 2024 •
edited by kjozwiak
Loading

Uplift of #25870
Resolves brave/brave-browser#41451
Resolves brave/brave-browser#41456

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Merge pull request #25870 from brave/set_brave_search_as_default_au
7e48784 
Set brave search as a default search provider in AU
@simonhong simonhong self-assigned this Oct 9, 2024
@simonhong simonhong requested a review from a team as a code owner October 9, 2024 01:13
@kjozwiak
Copy link
Member

kjozwiak commented Oct 9, 2024

As discussed with @rebron, the above will be uplifted/worked on in the next 1.71.x minor release which will target the week of October ~22-24. That's the dates we're expecting the minor C130 bump.

@kjozwiak kjozwiak added this to the 1.71.x - Release #2 milestone Oct 21, 2024
kjozwiak
kjozwiak approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.71.x approved 👍 QA has verified the PR on Nightly using 1.73.x as per #25870 (comment) & #25870 (comment).

@kjozwiak kjozwiak merged commit ddb3728 into 1.71.x Oct 21, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr25870_set_brave_search_as_default_au_1.71.x branch October 21, 2024 02:39
@brave-builds
Copy link
Collaborator

Released in v1.71.116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.71.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhong @kjozwiak @brave-builds