Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shields and rewards not being translated to Norwegian #2593

Merged
merged 1 commit into from
Jun 11, 2019
Merged

fix shields and rewards not being translated to Norwegian #2593

merged 1 commit into from
Jun 11, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#3425

Test Plan

  1. Change your OS locale to Norwegian
  2. Ensure both Shields and Rewards extensions are translated

@cezaraugusto cezaraugusto requested a review from bbondy June 4, 2019 19:55
@cezaraugusto cezaraugusto self-assigned this Jun 4, 2019
bsclifton
bsclifton reviewed Jun 4, 2019
View reviewed changes
BUILD.gn
@@ -226,7 +226,6 @@ if (!is_mac && !is_android && !is_ios) {
deps = [ "//brave/components/brave_rewards/resources/extension:locales_$locale" ]

locale = string_replace(locale, "-", "_")
locale = string_replace(locale, "nb", "no")
Copy link
Member

@bsclifton bsclifton Jun 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this here in the first place?
cc: @simonhong 34fa1de

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly I can't remember why I did like that - Maybe I also did copy & paste from other places..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbondy thoughts on this? cdbfca0#diff-71295ce804b64120ddc313f20e26c8adR135

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be that way in Chromium as well, my guess is they changed it on one of the rebases and we didn't update our code accordingly.

@bsclifton bsclifton requested a review from simonhong June 4, 2019 22:03
bsclifton
bsclifton approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased so that CI could run - everything passed beautifully 😄👌

Change itself worked great!
Skjermbilde 2019-06-10 kl 11 38 00 pm

@bsclifton bsclifton merged commit 7141b40 into master Jun 11, 2019
@bsclifton bsclifton deleted the ca-3425 branch June 11, 2019 06:39
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 11, 2019
bsclifton added a commit that referenced this pull request Jun 11, 2019
@bsclifton
Merge pull request #2593 from brave/ca-3425
4ad1577 
fix shields and rewards not being translated to Norwegian
bsclifton added a commit that referenced this pull request Jun 11, 2019
@bsclifton
Merge pull request #2593 from brave/ca-3425
c0b4710 
fix shields and rewards not being translated to Norwegian
This was referenced Jun 11, 2019
Merged
Merged
bsclifton added a commit that referenced this pull request Jun 11, 2019
@bsclifton
Merge pull request #2593 from brave/ca-3425
ee458d8 
fix shields and rewards not being translated to Norwegian
@bsclifton bsclifton mentioned this pull request Jun 11, 2019
Merged
@btlechowski btlechowski mentioned this pull request Jun 12, 2019
Closed
@mkarolin
Copy link
Collaborator

mkarolin commented Jun 14, 2019 •
edited
Loading

Unfortunately, I think this breaks Transifex translation. The files in nb locale return untranslated (in English). I am assuming Transifex doesn't translate because we don't have nb on the list of languages we want (can be added, but I think that means we'd be translating to no twice.). cc: @bbondy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

@yrliou yrliou Awaiting requested review from yrliou

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@cezaraugusto cezaraugusto

Labels
feature/rewards feature/shields l10n
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging this pull request may close these issues.

Shields Panel and Rewards Panel are not translated to Norwegian
6 participants
@cezaraugusto @mkarolin @bbondy @bsclifton @simonhong @NejcZdovc