Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Insufficient Balance on Swap #26409

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where the Swap screen was showing Insufficient Funds warning when selecting a token to swap with a balance.

Resolves brave/brave-browser#42141

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Swap screen
  2. Select a Token to swap that has a balance
  3. Enter an amount to swap
  4. You should not see an Insufficient Balance warning.

Before:

Screen.Recording.1.mov

After:

Screen.Recording.mov

@Douglashdaniel Douglashdaniel self-assigned this Nov 6, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner November 6, 2024 20:28
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Nov 6, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the fix-wallet-insufficient-balance-on-swap branch from 819365d to d7f01de Compare November 6, 2024 22:10
@Douglashdaniel Douglashdaniel merged commit d78c85f into master Nov 7, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-insufficient-balance-on-swap branch November 7, 2024 14:39
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 7, 2024
brave-builds added a commit that referenced this pull request Nov 7, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.3

@srirambv
Copy link
Contributor

srirambv commented Nov 8, 2024

Verification passed on

Brave 1.75.5 Chromium: 131.0.6778.39 (Official Build) nightly (64-bit)
Revision 733fcdb
OS Windows 11 Version 23H2 (Build 22631.4317)
  • Verified steps from PR
  • Verified balance shows up correctly on Swap screen
26049.mp4

kjozwiak pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap Screen is Showing Insufficient Balance Warning
4 participants