[Android] Fix for branding in browser_ui component strings
#26458
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| <message name="IDS_PAGE_INFO_AD_PRIVACY_HEADER" desc="A label that represents the new ad-related settings. 1) Navigate to any site. 2) Click the icon (often a lock) to the left of the URL in the address bar. Information about the page you're viewing appears. The 'Ad privacy' label will appear above the 'Site settings' button."> | ||
| Ad privacy | ||
| </message> | ||
| <message name="IDS_PAGE_INFO_AD_PRIVACY_TOPICS_DESCRIPTION" desc="1 of 3 possible descriptions a user might see when they choose 'Ad privacy' from page info for a specific site. 1) Navigate to any site. 2) Click the icon (often a lock) to the left of the URL in the address bar. Information about the page you're viewing appears. The 'Ad privacy' label will appear above the 'Site settings' button. 3) Click on Ad privacy. This string describes the case that the site being viewed uses the Ad topics setting. What's the Ad topics setting? When on, Brave will estimate the user's topics of interest based on their recent browsing history and then show up to 3 of those topics with a site so that the site can better personalize ads (a privacy-preserving way to replicate some of the functionality of third-party cookies). In this case, we're informing the user that this site uses the Ad topics API and we're showing the user the ad topics Brave has shared with the site. A button 'Manage ad privacy' allows the user to turn 'Ad privacy' settings on/off or to block specific ad topics."> |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Privacy claim found
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/privacy.yaml
Cc @bridiver @arthuredelstein @ShivanKaul @thypon
script/lib/l10n/grd_utils.py
Outdated
| if grd_file_name == 'site_settings.grdp': | ||
| return os.path.join(src_root, 'components', 'browser_ui', 'strings', | ||
| 'android', 'site_settings.grdp') |
There was a problem hiding this comment.
I don't think we need to add grdp files here.
There was a problem hiding this comment.
You're right this one is not required, pushed the change without it
samartnik
force-pushed
the
android_browser_ui_strings_fix
branch
from
d2a64d0
to
538b167
Compare
|
[puLL-Merge] - brave/brave-core@26458 DescriptionThis PR adds support for the ChangesChanges
Possible IssuesNo major issues identified. However, careful testing should be done to ensure all new strings are properly integrated and displayed in the Android UI. Security HotspotsNo significant security concerns identified in this change. The modifications are primarily related to string resources and build system updates. |
|
Released in v1.75.11 |
Resolves brave/brave-browser#42168
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: