Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DanglingPtr] Fix WebUIBubbleManagerImpl dangling patch #26465

Merged

Conversation

cdesouza-chromium
Copy link
Collaborator

A patch was added to WebUIBubbleManagerImpl when enabling the dangling pointer detector on Linux, as a temporary measure. This change corrects the the underlying issue requiring this pointer to be marked as dangling.

Resolves brave/brave-browser#42196

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Nov 10, 2024
A patch was added to `WebUIBubbleManagerImpl` when enabling the dangling
pointer detector on Linux, as a temporary measure. This change corrects
the the underlying issue requiring this pointer to be marked as
dangling.

This particular dangling pointer occurred because the toolbar view was
being passed as the achor for this browser data bubbles, the toolbar
gets destroyed prior to these browser data bubbles being disposed. This
PR adds checks during in the `BraveBrowserView` dtor, to make sure there
are no dangling references to the toolbar view by the time the
termination is cleaning up browser data.

Resolves brave/brave-browser#42196
@cdesouza-chromium cdesouza-chromium force-pushed the fix-webui-bubble-manager-impl-dangling-ptr-patch branch from 2a47fbb to 0181a9a Compare November 10, 2024 23:43
@cdesouza-chromium cdesouza-chromium marked this pull request as ready for review November 10, 2024 23:43
@cdesouza-chromium cdesouza-chromium requested a review from a team as a code owner November 10, 2024 23:43
@cdesouza-chromium cdesouza-chromium merged commit ec97acd into master Nov 11, 2024
17 checks passed
@cdesouza-chromium cdesouza-chromium deleted the fix-webui-bubble-manager-impl-dangling-ptr-patch branch November 11, 2024 17:22
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 11, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove patching for WebUIBubbleManagerImpl
3 participants