Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeHealth] Apply modernize-concat-nested-namespaces #26498

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

cdesouza-chromium
Copy link
Collaborator

This change modernises several namespace declarations, to be shorter, as this notation has been available since cxx17.

This is a mechanical change.

https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Nov 12, 2024
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet feature/web3/wallet/core labels Nov 12, 2024
Copy link
Member

@thypon thypon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sec gtg

This change modernises several namespace declarations, to be shorter, as
this notation has been available since cxx17.

https://clang.llvm.org/extra/clang-tidy/checks/modernize/concat-nested-namespaces.html
@cdesouza-chromium cdesouza-chromium force-pushed the apply-modernize-concat-nested-namespaces branch from cc60b9b to 48e0a04 Compare November 12, 2024 13:20
@cdesouza-chromium cdesouza-chromium merged commit d0becfc into master Nov 12, 2024
17 checks passed
@cdesouza-chromium cdesouza-chromium deleted the apply-modernize-concat-nested-namespaces branch November 12, 2024 17:00
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 12, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants