Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ads should only be sustained after the page has fully loaded #2658

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 11, 2019

Fixes brave/brave-browser#4798

Submitter Checklist:

Test Plan:

Confirm Ads are sustained 10 seconds after the page has fully loaded. On macOS you can use Network Link Conditioner to slow down the connection. Search console log for Sustained ad interaction

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 6d2151e into master Jun 11, 2019
@tmancey tmancey deleted the issues/4798 branch June 11, 2019 22:54
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Release notes for 0.58.x (Release)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ads should only be sustained after the page has fully loaded
2 participants