Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

brave / brave-core Public

Notifications You must be signed in to change notification settings
Fork 879
Star 2.5k

Code
Pull requests 229
Actions
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel Support for GitHub #2688

Merged

NejcZdovc merged 1 commit into master from github-tips

Jun 27, 2019

Merged

Panel Support for GitHub #2688

NejcZdovc merged 1 commit into master from github-tips

Jun 27, 2019

Conversation 15 Commits 1 Checks 0 Files changed

Conversation

Copy link

Contributor

jdkuki commented Jun 13, 2019 •

edited

Loading

Depends on :
brave/brave-ui#502

Resolves brave/brave-browser#4987

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Verified that these changes build without errors on
- Android
- iOS
- Linux
- macOS
- Windows
Verified that these changes pass automated tests (unit, browser, security tests) on
- iOS
- Linux
- macOS
- Windows
Verified that all lint errors/warnings are resolved (npm run lint)
Ran git rebase master (if needed).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.
Request a security/privacy review as needed.
Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
Public documentation has been updated as necessary. For instance:

Test Plan:

See steps in brave/brave-browser#4987

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

Sorry, something went wrong.

All reactions

jdkuki requested a review from NejcZdovc

June 13, 2019 18:03

jdkuki commented

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/bat_helper.cc Outdated Show resolved Hide resolved

jdkuki commented

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/bat_helper.cc Outdated Show resolved Hide resolved

jdkuki force-pushed the github-tips branch from 8ae6df1 to 2cf1298 Compare

June 13, 2019 21:30

NejcZdovc assigned NejcZdovc and jdkuki and unassigned NejcZdovc

NejcZdovc added the feature/rewards label

jdkuki mentioned this pull request

GitHub as Provider for panel support brave/brave-ui#502

Merged

9 tasks

jdkuki force-pushed the github-tips branch 2 times, most recently from 3c86ee2 to 5fff9b5 Compare

June 19, 2019 19:36

jdkuki marked this pull request as ready for review

June 19, 2019 19:37

jdkuki force-pushed the github-tips branch from 5fff9b5 to 1c42e7f Compare

June 19, 2019 19:37

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.h Outdated Show resolved Hide resolved

jdkuki force-pushed the github-tips branch 3 times, most recently from f32e1fa to ea1504e Compare

June 20, 2019 22:40

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc reviewed

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/media/github.cc Outdated Show resolved Hide resolved

NejcZdovc added this to the 0.68.x - Nightly milestone

jdkuki force-pushed the github-tips branch from ea1504e to 0857f74 Compare

June 21, 2019 19:51

NejcZdovc force-pushed the github-tips branch 2 times, most recently from 90e7832 to 588b754 Compare

June 25, 2019 10:08

jdkuki force-pushed the github-tips branch 4 times, most recently from 41d4c99 to dfeac9b Compare

June 25, 2019 22:01

NejcZdovc force-pushed the github-tips branch 3 times, most recently from 0e7cbe5 to 9aa19fe Compare

June 26, 2019 05:10


          Panel support for GitHub

061fb48

Resolves brave/brave-browser#4987

NejcZdovc force-pushed the github-tips branch from 9aa19fe to 061fb48 Compare

June 27, 2019 05:14

NejcZdovc approved these changes

View reviewed changes

NejcZdovc merged commit 89ce578 into master

NejcZdovc modified the milestones: 0.68.x - Dev, 0.69.x - Nightly

NejcZdovc deleted the github-tips branch

June 27, 2019 14:46

cg505 mentioned this pull request

brave-ui hash does not match between package.json and package-lock.json in brave-core brave/brave-browser#5042

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

NejcZdovc NejcZdovc approved these changes

Assignees

Labels

feature/rewards

Projects

None yet

Milestone

0.69.x-backup

Development

Successfully merging this pull request may close these issues.

Add Panel Support for GitHub

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.