Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add Base to preloaded EVM networks #27013

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

onyb
Copy link
Member

@onyb onyb commented Dec 13, 2024

Resolves brave/brave-browser#42885
Resolves brave/brave-browser#42884

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in linked issue

Comment on lines 109 to 111
inline constexpr char kBraveWalletCustomNetworksAuroraMainnetMigrated[] =
"brave.wallet.custom_networks.aurora_mainnet_migrated";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid being it a netsted pref of brave.wallet.custom_networks since it's already a separate pref
Just brave.wallet.aurora_mainnet_migrated would be enough

Yes, there is brave.wallet.custom_networks.fantom_mainnet_migrated above but such approach causes problems when fromat of parent pref gets changed.

PrefService* prefs,
const mojom::NetworkInfo& network,
bool is_eip1559,
const char* pref_key) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const char*
std::string_view

@onyb onyb force-pushed the f/wallet/base-aurora-preloads branch 2 times, most recently from 024ca81 to 9a2b689 Compare December 24, 2024 13:49
@onyb onyb force-pushed the f/wallet/base-aurora-preloads branch from 9a2b689 to bc09b5b Compare December 26, 2024 10:31
@onyb onyb requested a review from supermassive December 27, 2024 10:08
Copy link
Collaborator

@supermassive supermassive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet core lgtm

@onyb onyb merged commit a38d8e6 into master Dec 27, 2024
18 checks passed
@onyb onyb deleted the f/wallet/base-aurora-preloads branch December 27, 2024 13:25
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 27, 2024
brave-builds added a commit that referenced this pull request Dec 27, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.131

@srirambv
Copy link
Contributor

srirambv commented Jan 6, 2025

Verification passed on

Brave 1.75.142 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
Revision d6e67b9
OS Linux
  • Verified steps from issue description
  • Verified Aurora is removed from default network list on a clean profile
  • Verified if Aurora is set as default its retained as the the default network post upgrade
  • Verified if Aurora is not set as default it is removed from the list of default network
  • Verified Base is added as a default network on both clean and upgrade
27013.mp4

kjozwiak pushed a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Base to preloaded EVM networks Remove Aurora from preloaded EVM networks
4 participants