-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): add Base to preloaded EVM networks #27013
Conversation
inline constexpr char kBraveWalletCustomNetworksAuroraMainnetMigrated[] = | ||
"brave.wallet.custom_networks.aurora_mainnet_migrated"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid being it a netsted pref of brave.wallet.custom_networks
since it's already a separate pref
Just brave.wallet.aurora_mainnet_migrated
would be enough
Yes, there is brave.wallet.custom_networks.fantom_mainnet_migrated
above but such approach causes problems when fromat of parent pref gets changed.
PrefService* prefs, | ||
const mojom::NetworkInfo& network, | ||
bool is_eip1559, | ||
const char* pref_key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const char*
std::string_view
024ca81
to
9a2b689
Compare
9a2b689
to
bc09b5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallet core lgtm
Released in v1.75.131 |
Verification passed on
27013.mp4 |
Resolves brave/brave-browser#42885
Resolves brave/brave-browser#42884
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See STR in linked issue