Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pwa icon size #27130

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update pwa icon size #27130

merged 1 commit into from
Jan 7, 2025

Conversation

aguscruiz
Copy link
Collaborator

@aguscruiz aguscruiz commented Jan 6, 2025

Resolves brave/brave-browser#43114
Resolves brave/brave-browser#43008

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. If you already have the PWA version of either, uninstall it and install again.
  2. Open Leo AI full page and install it through the PWA installer button in the URL bar
  3. Open Password manager and install it through the PWA installer button in the URL bar
  4. You should see that the icon of the PWA is smaller, and it follows the size of the image on this PR

@aguscruiz aguscruiz enabled auto-merge (squash) January 6, 2025 19:12
@aguscruiz aguscruiz requested a review from a team as a code owner January 6, 2025 22:51
@aguscruiz aguscruiz requested review from a team as code owners January 7, 2025 19:43
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

[puLL-Merge] - brave/brave-core@27130

Description

This PR makes various changes across the codebase, including updates to the browser UI, wallet functionality, and several TypeScript files. The changes include improvements to the Brave Wallet, updates to browser menu components, and modifications to various settings pages.

Changes

Changes

  1. app/theme/brave/password_manager_logo.svg:

    • Updated SVG for password manager logo
  2. browser/resources/settings/:

    • Multiple TypeScript files updated with type annotations and code improvements
    • Changes to Brave Wallet, Adblock, and other settings pages
  3. browser/ui/views/brave_actions/brave_shields_action_view.cc:

    • Added check for extensions scheme in ShouldShowBubble function
  4. components/ai_chat/resources/page/pwa_icon.svg:

    • Updated SVG for PWA icon
  5. ios/brave-ios/:

    • Updates to BraveWebView, NFTView, and BrowserMenu components
    • Changes to DAU tests
  6. package.json:

    • Version bump to 1.75.152
  7. snapcraft.yaml:

    • Version bump to 1.75.152
sequenceDiagram
    participant User
    participant BraveUI
    participant BraveWallet
    participant Settings
    participant iOSApp

    User->>BraveUI: Interacts with browser
    BraveUI->>Settings: Update settings pages
    BraveUI->>BraveWallet: Integrate wallet functionality
    User->>iOSApp: Uses iOS app
    iOSApp->>BraveUI: Update UI components
    iOSApp->>Settings: Sync settings changes
Loading

Possible Issues

  • The removal of some @ts-nocheck comments may expose previously hidden TypeScript errors that need to be addressed.

Security Hotspots

None identified in this change set.

@fallaciousreasoning fallaciousreasoning changed the base branch from master to poc-ephemeral-tabs January 7, 2025 19:52
@aguscruiz aguscruiz merged commit 704889c into master Jan 7, 2025
16 checks passed
@aguscruiz aguscruiz deleted the pwa-icons branch January 7, 2025 21:20
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Jan 7, 2025
@brave-builds
Copy link
Collaborator

Released in v1.75.153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet puLL-Merge
Projects
None yet
4 participants