Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report one of several allowed screen sizes #27383

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented Jan 28, 2025

Change the screen fingerprinting protection to report one of just a few allowed screen sizes. Fixes an issue where a few websites would break on unusual screen dimensions.

Resolves brave/brave-browser#43555

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Change the screen fingerprinting protection to report one of
just a few allowed screen sizes. Fixes an issue where a few
websites would break on unusual screen dimensions.
@arthuredelstein arthuredelstein merged commit 8c56ea0 into master Jan 31, 2025
18 checks passed
@arthuredelstein arthuredelstein deleted the issues/43555 branch January 31, 2025 17:27
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Jan 31, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.7

@davidcollini
Copy link

Would this prevent websites from knowing your real screen size even when you’re fullscreen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some websites break on screen fingerprinting protection.
4 participants