Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup package.json. #27409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixup package.json. #27409

wants to merge 1 commit into from
+1 −1

Conversation

goodov
Copy link
Member

@goodov goodov commented Jan 30, 2025

Follow up for #27287 see the comment #27287 (comment)

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 30, 2025
@goodov goodov added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip Do not run CI builds (except noplatform) and removed CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Jan 30, 2025
@goodov goodov force-pushed the wdp-bump-node-22-followup branch from 4338137 to 574ac70 Compare January 30, 2025 06:39
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 30, 2025
@goodov goodov mentioned this pull request Jan 30, 2025
Merged
24 tasks
@goodov goodov marked this pull request as ready for review January 30, 2025 06:58
@goodov goodov requested a review from a team as a code owner January 30, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarier fmarier fmarier approved these changes

Assignees

@goodov goodov

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/skip Do not run CI builds (except noplatform) CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @fmarier