Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr133 follow up] Disables history embeddings features. (uplift to 1.76.x) #27417

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[cr133 follow up] Disables history embeddings features. (uplift to 1.76.x) #27417

merged 1 commit into from
Jan 30, 2025

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 30, 2025 •
edited by kjozwiak
Loading

Uplift of #27402
Resolves brave/brave-browser#43603

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 30, 2025 15:36
@brave-builds brave-builds added this to the 1.76.x - Beta milestone Jan 30, 2025
@brave-builds brave-builds self-assigned this Jan 30, 2025
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jan 30, 2025
kjozwiak
kjozwiak approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.76.x approved 👍

@kjozwiak kjozwiak merged commit d221adb into 1.76.x Jan 30, 2025
17 checks passed
@kjozwiak kjozwiak deleted the pr27402_maxk-disable-history-embeddings_1.76.x branch January 30, 2025 22:36
@brave-builds
Copy link
Collaborator Author

Released in v1.76.48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.76.x - Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak