Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(privacy): FrameCheckWrapper.js given incorrect value for url comparison (uplift to 1.75.x) #27420

Open
wants to merge 1 commit into
base: 1.75.x
Choose a base branch
from
Open

fix(privacy): FrameCheckWrapper.js given incorrect value for url comparison (uplift to 1.75.x) #27420

wants to merge 1 commit into from
+65 −1

Conversation

brave-builds
Copy link
Collaborator

Uplift of #27320
Resolves brave/brave-browser#43454

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 30, 2025 16:25
@brave-builds brave-builds added this to the 1.75.x - Release milestone Jan 30, 2025
@brave-builds brave-builds self-assigned this Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Chromium major version is behind target branch (132.0.6834.160 vs 133.0.6943.39). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Jan 30, 2025
@StephenHeaps StephenHeaps force-pushed the pr27320_bugfix/frame-check-wrapper-youtube_1.75.x branch from 5c8e579 to 4586604 Compare January 30, 2025 22:45
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Jan 30, 2025
@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @StephenHeaps