scripts to build linux installer packages #28

AlexeyBarabash · 2018-02-01T10:23:53Z

This PR for issue brave/brave-browser-snap#19 .
Now command npm run create_dist or npm run create_dist -- --debug_build=true --official_build=false creates these packages:

brave-browser-chromium-fork-stable-64.0.3282.119-1.x86_64.rpm
brave-browser-chromium-fork-stable_64.0.3282.119-1_amd64.deb
brave-browser-chromium-fork-beta-64.0.3282.119-1.x86_64.rpm
brave-browser-chromium-fork-beta_64.0.3282.119-1_amd64.deb
brave-browser-chromium-fork-unstable-64.0.3282.119-1.x86_64.rpm
brave-browser-chromium-fork-unstable_64.0.3282.119-1_amd64.deb

rpm and deb for each of channel stable, beta, unstable.

There are two points with this PR:

Web repository for command line is not created yet.
Build script complaints for missing dependencies during creating of rpm package. I have disabled it https://github.com/brave/antimuon/compare/linux_installer_packages?expand=1#diff-b17d27146c2b5403e627bec090114c86R10 . Tested on Fedora 27, 26 installation succeeded, probably it pulls deps from the network. If this is not appropriate, I will search for the way to include missing binaries.

bbondy · 2018-02-01T13:29:03Z

Thanks!

Web repository for command line is not created yet.

No need to work on that part, we can re-use what we do for the browser-laptop based current desktop software.

2...

I think it would be good if we can find a way to avoid that patch and have the dep.

bbondy · 2018-02-03T18:25:01Z

patches/chrome-installer-linux-BUILD.gn.patch

 + "//brave/chromium_src/chrome/installer/linux/common/brave-browser/chromium-browser.appdata.xml",
 + "//brave/chromium_src/chrome/installer/linux/common/brave-browser/chromium-browser.info",
- ]


I think this patch can be cleaner just by removing lines 29 and 30 and replacing with lines 36 and 37

Yes, fixed.

bbondy · 2018-02-03T18:26:37Z

chromium_src/chrome/installer/linux/common/brave-browser/chromium-browser.appdata.xml

+ </p>
+ </description>
+ <url type="homepage">https://brave.com/</url>
+ <screenshots>


Is it better to completely remove the screenshots element?

Agree, removed.

bbondy · 2018-02-03T18:27:18Z

patches/chrome-installer-linux-BUILD.gn.patch

 ]
 packaging_files_shlibs = []
+


remove extra blank newline

Thanks for finding, fixed.

bbondy · 2018-02-03T18:27:43Z

patches/chrome-installer-linux-BUILD.gn.patch

+ sources += [
+ "//brave/chromium_src/chrome/installer/linux/common/brave-browser/chromium-browser.appdata.xml",
+ "//brave/chromium_src/chrome/installer/linux/common/brave-browser/chromium-browser.info",
+ ]


Just remove lines 26-27 and replace with lines 36-37 here, thanks.

This is done.
The reason why I have done that is the message in #chromium-fork from @bridiver

when you are replacing a source file in a chrome gn file you should add a patch with `source -=` and `source +=` vs patching inline in the existing `source =`

But patches here is fragile balance between minimal size for future support and clarity. Direct patch does make the size of result smaller, without obvious damage for clarity. So, thanks for mention about issue.

bbondy · 2018-02-03T18:28:04Z

patches/chrome-installer-linux-rpm-calculate_package_deps.py.patch

+ requirement, distro, os.path.basename(binary)))
+- ret_code = 1
+ # Disabled to finish the build. Some deps may be missing, but rpm is well installed.
+ #ret_code = 1


Please resolve this

The build of rpm packages requires to run on Ubuntu 14.
This patch is removed now.

bbondy

comments inline

bridiver · 2018-02-03T18:29:07Z

patches/chrome-installer-linux-BUILD.gn.patch

+ if (is_chrome_branded) {
+ package = "google-chrome"
+ } else {
+- package = "chromium-browser"


where is this name actually used? If this is a deb we don't want "-chromium-fork" here. If this package name isn't seen by users or if we can just rename it afterwards then I think we shouldn't patch it at all

This line in brave/src/chrome/installer/linux/BUILD.gn does not used anywhere indeed. The package name is defined by the line PACKAGE="brave-browser" at the file https://github.com/brave/antimuon/pull/28/files#diff-a023e566679169856984037106482f04R9 . I have modified this line in prev commits to have consistency between installer/linux/BUILD.gn and chromium-browser.info. Now this is removed.

Thanks for notice, I got rid of chromium-fork mention everywhere, but I have left the package name modified, because it is taken from completely overridden file chromium_src/chrome/installer/linux/common/brave-browser/chromium-browser.info (https://github.com/brave/antimuon/pull/28/files#diff-a023e566679169856984037106482f04R1) and does not affect the patch complexity.

AlexeyBarabash · 2018-02-06T15:43:59Z

Removed workaround patch for calculate_package_deps.py.
On Ubuntu 14 command /usr/lib/rpm/find-requires gives result without rtld(GNU_HASH).
On Ubuntu 16 even on clean install, Ubuntu 17 there is an item rtld(GNU_HASH) in output which breaks the build.
Ubuntu 14 uses rpm of version 4.11.1-3ubuntu0.1 , Ubuntu 16 uses 4.12.0.1+dfsg1-3build3, Ubuntu 17 uses 4.12.0.2+dfsg1-2build2 . And rpm version 4.11 is not available for Ubuntu 16.

Just in case the build is being configured and will be checked in Ubuntu 14.

AlexeyBarabash · 2018-02-06T15:50:52Z

@bbondy , @bridiver
~~PR is ready to have your review again. Thanks.~~

IOError: [Errno 2] No such file or directory: '../../chrome/app/theme/brave/BRANDING'
will add dependency in gn
don't start review

AlexeyBarabash · 2018-02-06T20:38:31Z

Fixed issue with build after checkout. Fix is in https://github.com/brave/brave/pull/67 .
The build of all packages succeeded on Ubuntu 14.04 after checkout.

This PR is ready for review, @bbondy , @bridiver.

bbondy · 2018-02-09T05:21:33Z

Could you make the namesbrave-x86_64.rpm and brave-amd64.deb?
If it requires a patch file in chromium src then pls just copy them to the out dir (src/out/Release)

Also secondary priority and can come in a diff PR, but pls make sure it also works with target_arch=x86

npm run build -- --target_arch=x86
npm run create_dist  -- --target_arch=x86

Remove FETCH_CALLBACK_EXTRA_DATA_ST structure

Update @types/react-redux to fix TS2344 error during build

scripts to build linux installer packages

645dd31

AlexeyBarabash requested review from bridiver and bbondy February 1, 2018 10:23

AlexeyBarabash mentioned this pull request Feb 1, 2018

Create Linux packages and repos for Linux brave/brave-browser#19

Closed

modified patch to have more visualized changes

c422d9d

bbondy reviewed Feb 3, 2018

View reviewed changes

bbondy requested changes Feb 3, 2018

View reviewed changes

bridiver reviewed Feb 3, 2018

View reviewed changes

AlexeyBarabash added 2 commits February 5, 2018 10:29

fixes after code review

d256c2f

removed workaround patch for rpm

9e33e01

AlexeyBarabash added 2 commits February 6, 2018 18:47

get back line break

7b57214

removed line break

63c9ce8

bbondy assigned AlexeyBarabash Feb 9, 2018

bbondy approved these changes Feb 9, 2018

View reviewed changes

bbondy merged commit 6e470cc into master Feb 9, 2018

bsclifton deleted the linux_installer_packages branch June 18, 2018 06:26

NejcZdovc pushed a commit that referenced this pull request Dec 10, 2018

Merge pull request #28 from brave-intl/bind_args_directly

51d9b8e

Remove FETCH_CALLBACK_EXTRA_DATA_ST structure

mbacchi mentioned this pull request Jan 16, 2019

Remove dl.google.com repository from Linux packages #1078

Merged

18 tasks

bbondy added a commit that referenced this pull request Feb 18, 2019

Merge pull request #28 from brave/fix-TS2344-error

e8b5d46

Update @types/react-redux to fix TS2344 error during build

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scripts to build linux installer packages #28

scripts to build linux installer packages #28

AlexeyBarabash commented Feb 1, 2018

bbondy commented Feb 1, 2018

bbondy Feb 3, 2018 •

edited

Loading

AlexeyBarabash Feb 5, 2018

bbondy Feb 3, 2018

AlexeyBarabash Feb 5, 2018

bbondy Feb 3, 2018

AlexeyBarabash Feb 5, 2018

bbondy Feb 3, 2018

AlexeyBarabash Feb 5, 2018

bbondy Feb 3, 2018

AlexeyBarabash Feb 6, 2018

bbondy left a comment

bridiver Feb 3, 2018

AlexeyBarabash Feb 5, 2018

AlexeyBarabash commented Feb 6, 2018

AlexeyBarabash commented Feb 6, 2018 •

edited

Loading

AlexeyBarabash commented Feb 6, 2018

bbondy commented Feb 9, 2018

scripts to build linux installer packages #28

scripts to build linux installer packages #28

Conversation

AlexeyBarabash commented Feb 1, 2018

bbondy commented Feb 1, 2018

bbondy Feb 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bbondy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexeyBarabash commented Feb 6, 2018

AlexeyBarabash commented Feb 6, 2018 • edited Loading

AlexeyBarabash commented Feb 6, 2018

bbondy commented Feb 9, 2018

bbondy Feb 3, 2018 •

edited

Loading

AlexeyBarabash commented Feb 6, 2018 •

edited

Loading