Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent: Fit video/audio media to window size #3005

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

feross
Copy link
Contributor

@feross feross commented Jul 25, 2019

Fixes: brave/brave-browser#1229

Supercedes and closes: #2261

Before:
Screen Shot 2019-07-24 at 5 52 28 PM

After:
Screen Shot 2019-07-24 at 5 52 30 PM

Before:
Screen Shot 2019-07-24 at 5 51 47 PM

After:
Screen Shot 2019-07-24 at 5 51 52 PM

Submitter Checklist:

Test Plan:

Video:

  1. Go to https://webtorrent.io/free-torrents
  2. Click on Big Buck Bunny (magnet link)
  3. Select the MP4 file.
  4. It should open and fit nicely into the browser window, with nothing offscreen.

Audio:

  1. Go to https://webtorrent.io/free-torrents
  2. Click on Wired CD (magnet link)
  3. Select any MP3 file.
  4. It should open and fit nicely into the center of the browser window with a background.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@feross feross added the feature/webtorrent Label for webtorrent related issues label Jul 25, 2019
@feross feross added this to the 0.70.x - Nightly milestone Jul 25, 2019
@feross feross requested a review from yrliou July 25, 2019 00:59
@feross feross self-assigned this Jul 25, 2019
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross merged commit fa0b05c into master Jul 25, 2019
@feross feross deleted the webtorrent-fit branch August 1, 2019 23:29
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Update iOS repository information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/webtorrent Label for webtorrent related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fit Torrent media to window size
2 participants