Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of P3A (Privacy-Preserving Product Analytics) #3242

Merged
merged 75 commits into from
Oct 2, 2019
Merged

Initial implementation of P3A (Privacy-Preserving Product Analytics) #3242

merged 75 commits into from
Oct 2, 2019

Commits on Sep 29, 2019

  1. The initial Privacy-Preserving Product Analytics impl.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    6982b45 View commit details
    Browse the repository at this point in the history

  2. P3A: Add some VLOGs to the core service.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    8b7dbea View commit details
    Browse the repository at this point in the history

  3. P3A: adding Week of Survey, Country Code, Refcode.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    017e463 View commit details
    Browse the repository at this point in the history

  4. P2A: Add years of install and survey to the packet

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    86d933a View commit details
    Browse the repository at this point in the history

  5. P3A: Fix threading issue in p3a service.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    81770af View commit details
    Browse the repository at this point in the history

  6. P3A: Adding a sync status histogram.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    e995099 View commit details
    Browse the repository at this point in the history

  7. P3A: Importer source histogram.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b6ee44b View commit details
    Browse the repository at this point in the history

  8. Clang-format.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    15a7505 View commit details
    Browse the repository at this point in the history

  9. P3A: Adding metric for shields usage status.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    a2cf68a View commit details
    Browse the repository at this point in the history

  10. P3A: Adding windows/tabs and other core metrics.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    9a82351 View commit details
    Browse the repository at this point in the history

  11. P2A: Rewards metrics.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    1d8126d View commit details
    Browse the repository at this point in the history

  12. P3A: Typo in ads metrics.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    01f3598 View commit details
    Browse the repository at this point in the history

  13. P3A: Uptime metrics.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    a56222f View commit details
    Browse the repository at this point in the history

  14. P3A: Onboarding metric.

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b07100f View commit details
    Browse the repository at this point in the history

  15. Encode p3a protobuf to base64.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    7127bb4 View commit details
    Browse the repository at this point in the history

  16. P3A: updating prochlo keys.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    575f652 View commit details
    Browse the repository at this point in the history

  17. Update main p3a URL.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    c1c8654 View commit details
    Browse the repository at this point in the history

  18. Adjusting the uploading interval randomization.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    f780b64 View commit details
    Browse the repository at this point in the history

  19. P3A: Fix macos build.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    462d9c5 View commit details
    Browse the repository at this point in the history

  20. Fixing the MacOS build.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b90ddb9 View commit details
    Browse the repository at this point in the history

  21. Pleasing the linter.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    47123c1 View commit details
    Browse the repository at this point in the history

  22. Pinning certificates for P3A endpoints.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    d0e63f4 View commit details
    Browse the repository at this point in the history

  23. P3A: Improving randomization of uploads order.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    91ca988 View commit details
    Browse the repository at this point in the history

  24. Minor compilation fix after rebase.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    88339fc View commit details
    Browse the repository at this point in the history

  25. P3A: Adding brave-specific header to P3A upload requests.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b8848e6 View commit details
    Browse the repository at this point in the history

  26. P3A: Adding traces to cpu-heavy functions.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    4ced136 View commit details
    Browse the repository at this point in the history

  27. P3A: Improve upload interval randomization.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    bb15b1b View commit details
    Browse the repository at this point in the history

  28. Clang-format.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    2e573bf View commit details
    Browse the repository at this point in the history

  29. P3A: Making metrics buckets even more private.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    72ceefc View commit details
    Browse the repository at this point in the history

  30. P3A: Save the bare minimum of stats regarding tor.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    6088598 View commit details
    Browse the repository at this point in the history

  31. P3A: Disable PROCHLO.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    2f11a62 View commit details
    Browse the repository at this point in the history

  32. P3A: Fix the Answer Count metric.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    19fcaac View commit details
    Browse the repository at this point in the history

  33. Fix compilation errors

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    1ec80b1 View commit details
    Browse the repository at this point in the history

  34. Initial implementation of P3A infobar

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    5474b74 View commit details
    Browse the repository at this point in the history

  35. Added P3A setting to brave://settings 

    Don't upload if P3A preference is disabled.
    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    526aec3 View commit details
    Browse the repository at this point in the history

  36. Cleanup per review feedback 

    - Ran clang-format to clean up files modified
- Added TODOs for commented out code
    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    e20f494 View commit details
    Browse the repository at this point in the history

  37. Fixed most compile errors that happened after rebase

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    da2a2bb View commit details
    Browse the repository at this point in the history

  38. p3a welcome screen

    @rossmoody
    rossmoody authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    2ef207e View commit details
    Browse the repository at this point in the history

  39. Don't show P3A infobar for new users; they are shown a different noti… 

    …ce in the welcome page.
    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b964eef View commit details
    Browse the repository at this point in the history

  40. Update shields logic after refactor was done with #3033

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    23bb018 View commit details
    Browse the repository at this point in the history

  41. Fix compile error for P3A wallet question

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    d164e02 View commit details
    Browse the repository at this point in the history

  42. Update string on shields (p3a) page to be tokenized

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    30438b8 View commit details
    Browse the repository at this point in the history

  43. Small text change to welcome page, per feedback

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    d5f297f View commit details
    Browse the repository at this point in the history

  44. Final tweaks, per @bradleyrichter and @diracdeltas 

    - Rewording on Shields / P3A welcome screen
- Theme welcome screen removed
- Shields / P3A welcome screen moved to index 3
    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b5c9ff9 View commit details
    Browse the repository at this point in the history

  45. Updates to network annotation per review feedback

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    5fc97f8 View commit details
    Browse the repository at this point in the history

  46. Update to use smart quotes on welcome screen

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    c6077e4 View commit details
    Browse the repository at this point in the history

  47. Lint clean up (both C++ and JS)

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    ed109c2 View commit details
    Browse the repository at this point in the history

  48. unit test fix, after const was removed from method

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    f91e896 View commit details
    Browse the repository at this point in the history

  49. Minor renaming.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    242e1ea View commit details
    Browse the repository at this point in the history

  50. Delete obsolete file (theme screen was removed) 

    This fixes errors with the JavaScript unit tests
    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    f8d6f99 View commit details
    Browse the repository at this point in the history

  51. Fix Windows compile error

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    56dec6c View commit details
    Browse the repository at this point in the history

  52. more windows specific fixes

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    c288726 View commit details
    Browse the repository at this point in the history

  53. Fix nits

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    dc04788 View commit details
    Browse the repository at this point in the history

  54. P3A: Fix android build.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    db85f06 View commit details
    Browse the repository at this point in the history

  55. Simplifying query in rewards P3A.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    6850f1b View commit details
    Browse the repository at this point in the history

  56. P3A: Extract some code to a separate file.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    4af229a View commit details
    Browse the repository at this point in the history

  57. rename BraveWindowsTracker => BraveWindowTracker

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    f485f60 View commit details
    Browse the repository at this point in the history

  58. Updated shields graphic, per Karen :)

    @bsclifton
    bsclifton authored and Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    cb79e1e View commit details
    Browse the repository at this point in the history

  59. Improve P3A GN files.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    2f114cc View commit details
    Browse the repository at this point in the history

  60. P3A: refactor shields stats.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    faf20d2 View commit details
    Browse the repository at this point in the history

  61. Minor refactoring of ads P3A.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    2e6802d View commit details
    Browse the repository at this point in the history

  62. Minor rename.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    a9e0160 View commit details
    Browse the repository at this point in the history

  63. Minor renaming.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    8657cdd View commit details
    Browse the repository at this point in the history

  64. P3A infobar: fix android build.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    7beddf1 View commit details
    Browse the repository at this point in the history

  65. Pleasing linter.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    0a06899 View commit details
    Browse the repository at this point in the history

  66. Fixing build, disabling P3A on android.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    54bedf0 View commit details
    Browse the repository at this point in the history

  67. Fix tests after rebase.

    Ivan Efremov committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    26ec2c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Fix android build.

    Ivan Efremov committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    795ef88 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Minor rewording in rewards service.

    Ivan Efremov committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    6637ae8 View commit details
    Browse the repository at this point in the history

  2. Restore occasionally deleted block.

    Ivan Efremov committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    05a27da View commit details
    Browse the repository at this point in the history

  3. Better OS and feature guards for P3A.

    Ivan Efremov committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    5505737 View commit details
    Browse the repository at this point in the history

  4. Some more deps.

    Ivan Efremov committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    d428fa1 View commit details
    Browse the repository at this point in the history

  5. Drop unwanted dep.

    Ivan Efremov committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    5c5fe9f View commit details
    Browse the repository at this point in the history

  6. Add missing dependency for p3a. 

    It needs brave_base in dep list.
    @simonhong
    simonhong committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    24e28f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Check null local_state in tests.

    Ivan Efremov committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    66dd2fd View commit details
    Browse the repository at this point in the history