Crash fix for back button around newtab #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
requested changes
Aug 16, 2018
browser/ui/webui/brave_new_tab_ui.cc
Outdated
| render_view_host = web_contents->GetRenderViewHost(); | ||
| } | ||
| } | ||
| if (render_view_host) { |
There was a problem hiding this comment.
Looks like this check duplicates the check on the next line.
|
Thanks. PR read for re-review. |
|
Verified builds and tests pass on macOS, Windows, Linux. |
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
Use jumbo build to non-official build
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
Use jumbo build to non-official build
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
Use jumbo build to non-official build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#708
Fix brave/brave-browser#707
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: