Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in support for the wayback machine #3561

Merged
merged 21 commits into from
Dec 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ed1a1c4
Add basic support for Wayback Machine extension
cezaraugusto Oct 29, 2019
2d0b5f0
Provide a switch in settings for Wayback Machine
cezaraugusto Oct 30, 2019
bea69f0
Add browser tests for Wayback Machine
cezaraugusto Oct 30, 2019
4f55bf0
Create `Help Tips` section in settings
cezaraugusto Oct 30, 2019
f09faa3
Refactor and cleanup
simonhong Nov 26, 2019
9513483
Use TabHelper for detecting 404 response instead of using extension
simonhong Nov 27, 2019
fc92c74
Implement infobar for Wayback machine
simonhong Dec 2, 2019
f9957ab
Introduce WaybackMachineURLFetcher
simonhong Dec 4, 2019
1187c44
Refactor InfoBar view classes
simonhong Dec 5, 2019
04eeb7f
Hide wayback machine option if it's not built
simonhong Dec 5, 2019
9271d20
Show throbber animation while wayback url fetching is in progress
simonhong Dec 6, 2019
c1d72e6
Apply real wayback infobar image resources
simonhong Dec 6, 2019
7f897aa
Enable wayback machine only on desktop build
simonhong Dec 9, 2019
d92dd2b
Replace sad folder icon
simonhong Dec 9, 2019
24a7389
Apply brave theme color to separator and icon
simonhong Dec 9, 2019
45d0910
Add wayback query url to url_constatns.h
simonhong Dec 9, 2019
17e7431
Fix lint error
simonhong Dec 9, 2019
9cf41fa
Make brave_wayback_machine component module
simonhong Dec 12, 2019
7402ff1
Added missing sentence into copyright paragraph
simonhong Dec 17, 2019
d0c0cd8
Introduce AttachTabHelperIfNeeded to wayback machine delegate impl
simonhong Dec 17, 2019
84400ed
Change BraveWaybackMahcineDelegate interface
simonhong Dec 18, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ browser/net/ @iefremov
# Widevine
browser/widevine @simonhong

# Wayback machine
browser/ui/views/infobars/brave_wayback_machine_* @simonhong
components/brave_wayback_machine @simonhong

# Licensing of third-party components
common/licenses/ @fmarier
components/brave_new_tab_ui/data/backgrounds.ts @fmarier
Expand Down
20 changes: 20 additions & 0 deletions app/brave_generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,13 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
<message name="IDS_SETTINGS_BRAVE_SYNC_LINK_LABEL" desc="Brave Sync link label">
Access Sync via
</message>
<!-- Help Tips Page -->
<message name="IDS_SETTINGS_HELP_TIPS" desc="Title for an item in the 'Help Tips' section of Brave Settings">
Help Tips
</message>
<message name="IDS_SETTINGS_HELP_TIPS_SHOW_BRAVE_WAYBACK_MACHINE_PROMPT" desc="The label describing the 'wayback machine' toggle option">
Show Wayback Machine prompt on 404 pages
</message>
<!-- Brave Theme -->
<message name="IDS_BRAVE_THEME_TYPE_LIGHT" desc="Text for light theme type">
Light
Expand Down Expand Up @@ -665,6 +672,19 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
<message name="IDS_BRAVE_CRYPTO_WALLETS_SETUP" desc="Use Crypto Wallets">
SETUP
</message>
<!-- Brave Wayback Machine -->
<message name="IDS_BRAVE_WAYBACK_MACHINE_INFOBAR_PAGE_MISSING_TEXT" desc="The label for sorry message when page is not available on infobar">
Sorry, that page is missing.
</message>
<message name="IDS_BRAVE_WAYBACK_MACHINE_INFOBAR_ASK_ABOUT_CHECK_TEXT" desc="The label for asking to check from wayback machine">
Do you want to check if a saved version is available on the Wayback Machine?
</message>
<message name="IDS_BRAVE_WAYBACK_MACHINE_INFOBAR_NOT_AVAILABLE_TEXT" desc="The label for wayback machine doesn't have saved version">
Sorry, there is no saved version available.
</message>
<message name="IDS_BRAVE_WAYBACK_MACHINE_CHECK_BUTTON_TEXT" desc="The label for check button on wayback infobar">
Check for saved version
</message>
<!-- Brave's copyright statement -->
<message name="IDS_BRAVE_VERSION_UI_LICENSE" desc="The label below the copyright message, containing the URLs.">
Brave is made available to you under the <ph name="BEGIN_LINK_MPL">&lt;a target="_blank" href="$1"&gt;</ph>Mozilla Public License 2.0<ph name="END_LINK_MPL">&lt;/a&gt;</ph> (MPL) and includes <ph name="BEGIN_LINK_OSS">&lt;a target="_blank" href="$2"&gt;</ph>open source software<ph name="END_LINK_OSS">&lt;/a&gt;</ph> under a variety of other licenses.
Expand Down
1 change: 1 addition & 0 deletions app/theme/brave_theme_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<!-- KEEP THESE IN ALPHABETICAL ORDER! DO NOT ADD TO RANDOM PLACES JUST
BECAUSE YOUR RESOURCES ARE FUNCTIONALLY RELATED OR FALL UNDER THE
SAME CONDITIONALS. -->
<structure type="chrome_scaled_image" name="IDR_BRAVE_WAYBACK_INFOBAR" file="brave/brave_wayback_infobar.png" />
<structure type="chrome_scaled_image" name="IDR_PRODUCT_LOGO_32_BETA" file="brave/product_logo_32_beta.png" />
<structure type="chrome_scaled_image" name="IDR_PRODUCT_LOGO_32_CANARY" file="brave/product_logo_32_nightly.png" />
<structure type="chrome_scaled_image" name="IDR_PRODUCT_LOGO_32_DEV" file="brave/product_logo_32_dev.png" />
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion app/vector_icons/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ aggregate_vector_icons("brave_vector_icons") {
icons = [
"autoplay_status.icon",
"download_unlock.icon",
"sad_folder.icon",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheer up, folder icon; it's Friday! 😄

"tor_profile.icon",
]
}
Expand All @@ -23,4 +24,4 @@ source_set("vector_icons") {
"//skia",
"//ui/gfx",
]
}
}
51 changes: 51 additions & 0 deletions app/vector_icons/sad_folder.icon
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
// Copyright (c) 2019 The Brave Authors. All rights reserved.
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at http://mozilla.org/MPL/2.0/.

CANVAS_DIMENSIONS, 22,
MOVE_TO, 8.77f, 2.75f,
R_CUBIC_TO, 0.15f, 0, 0.29f, 0.04f, 0.41f, 0.13f,
LINE_TO, 11.23f, 4.26f,
R_H_LINE_TO, 7.22f,
R_CUBIC_TO, 0.82f, 0, 1.49f, 0.68f, 1.49f, 1.51f,
R_V_LINE_TO, 10.59f,
R_CUBIC_TO, 0, 0.83f, -0.67f, 1.51f, -1.49f, 1.51f,
H_LINE_TO, 3.55f,
R_CUBIC_TO, -0.82f, 0, -1.49f, -0.68f, -1.49f, -1.51f,
R_V_LINE_TO, -12.1f,
R_CUBIC_TO, 0, -0.83f, 0.67f, -1.51f, 1.49f, -1.51f,
H_LINE_TO, 8.77f,
CLOSE,
R_MOVE_TO, -0.23f, 1.51f,
R_H_LINE_TO, -4.99f,
R_V_LINE_TO, 12.1f,
H_LINE_TO, 18.45f,
V_LINE_TO, 5.78f,
R_H_LINE_TO, -7.44f,
R_CUBIC_TO, -0.07f, 0, -0.15f, -0.01f, -0.22f, -0.03f,
R_CUBIC_TO, -0.08f, -0.02f, -0.15f, -0.06f, -0.21f, -0.1f,
LINE_TO, 8.54f, 4.26f,
CLOSE,
MOVE_TO, 11, 11.07f,
R_CUBIC_TO, 1.18f, 0, 2.34f, 0.49f, 3.46f, 1.43f,
R_CUBIC_TO, 0.32f, 0.27f, 0.36f, 0.74f, 0.1f, 1.07f,
R_CUBIC_TO, -0.26f, 0.32f, -0.73f, 0.36f, -1.05f, 0.1f,
CUBIC_TO, 12.64f, 12.93f, 11.81f, 12.58f, 11, 12.58f,
R_CUBIC_TO, -0.81f, 0, -1.64f, 0.35f, -2.5f, 1.08f,
R_CUBIC_TO, -0.32f, 0.27f, -0.79f, 0.22f, -1.05f, -0.1f,
R_CUBIC_TO, -0.26f, -0.32f, -0.22f, -0.8f, 0.1f, -1.07f,
CUBIC_TO, 8.66f, 11.56f, 9.82f, 11.07f, 11, 11.07f,
CLOSE,
R_MOVE_TO, -2.23f, -3.02f,
R_CUBIC_TO, 0.41f, 0, 0.74f, 0.34f, 0.74f, 0.76f,
R_CUBIC_TO, 0, 0.42f, -0.33f, 0.76f, -0.74f, 0.76f,
R_CUBIC_TO, -0.41f, 0, -0.74f, -0.34f, -0.74f, -0.76f,
R_CUBIC_TO, 0, -0.42f, 0.33f, -0.76f, 0.74f, -0.76f,
CLOSE,
R_MOVE_TO, 4.47f, 0,
R_CUBIC_TO, 0.41f, 0, 0.74f, 0.34f, 0.74f, 0.76f,
R_CUBIC_TO, 0, 0.42f, -0.33f, 0.76f, -0.74f, 0.76f,
R_CUBIC_TO, -0.41f, 0, -0.74f, -0.34f, -0.74f, -0.76f,
R_CUBIC_TO, 0, -0.42f, 0.33f, -0.76f, 0.74f, -0.76f,
CLOSE
10 changes: 9 additions & 1 deletion browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import("//brave/browser/tor/buildflags/buildflags.gni")
import("//brave/components/brave_ads/browser/buildflags/buildflags.gni")
import("//brave/components/brave_sync/buildflags/buildflags.gni")
import("//brave/components/brave_wallet/browser/buildflags/buildflags.gni")
import("//brave/components/brave_wayback_machine/buildflags/buildflags.gni")
import("//brave/components/brave_webtorrent/browser/buildflags/buildflags.gni")
import("//brave/components/greaselion/browser/buildflags/buildflags.gni")
import("//build/buildflag_header.gni")
Expand Down Expand Up @@ -118,9 +119,9 @@ source_set("browser_process") {
"renderer_host",
"ui",
"//base",
"//brave/browser/notifications",
"//brave/browser/tor:buildflags",
"//brave/browser/translate/buildflags",
"//brave/browser/notifications",
"//brave/common",
"//brave/common:pref_names",
"//brave/components/brave_ads/browser",
Expand All @@ -130,6 +131,7 @@ source_set("browser_process") {
"//brave/components/brave_rewards/browser",
"//brave/components/brave_shields/browser",
"//brave/components/brave_wallet/browser",
"//brave/components/brave_wayback_machine:buildflags",
"//brave/components/brave_webtorrent/browser/buildflags",
"//brave/components/content_settings/core/browser",
"//brave/components/greaselion/browser/buildflags",
Expand Down Expand Up @@ -263,6 +265,12 @@ source_set("browser_process") {
]
}

if (enable_brave_wayback_machine) {
deps += [
"//brave/components/brave_wayback_machine",
]
}

if (enable_widevine) {
sources += [
"brave_drm_tab_helper.cc",
Expand Down
10 changes: 10 additions & 0 deletions browser/brave_profile_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "brave/common/pref_names.h"
#include "brave/components/brave_shields/browser/brave_shields_web_contents_observer.h"
#include "brave/components/brave_sync/brave_sync_prefs.h"
#include "brave/components/brave_wayback_machine/buildflags.h"
#include "brave/components/brave_webtorrent/browser/buildflags/buildflags.h"
#include "chrome/browser/net/prediction_options.h"
#include "chrome/browser/prefs/session_startup_pref.h"
Expand Down Expand Up @@ -38,6 +39,10 @@
#include "brave/browser/widevine/widevine_utils.h"
#endif

#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
#include "brave/components/brave_wayback_machine/pref_names.h"
#endif

using extensions::FeatureSwitch;

namespace brave {
Expand Down Expand Up @@ -96,6 +101,11 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
webtorrent::RegisterProfilePrefs(registry);
#endif

// wayback machine
#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
registry->RegisterBooleanPref(kBraveWaybackMachineEnabled, true);
#endif

#if defined(OS_ANDROID)
registry->RegisterBooleanPref(kDesktopModeEnabled, false);
registry->RegisterBooleanPref(kPlayYTVideoInBrowserEnabled, true);
Expand Down
9 changes: 9 additions & 0 deletions browser/brave_profile_prefs_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "brave/common/pref_names.h"
#include "brave/components/brave_wayback_machine/buildflags.h"
#include "chrome/browser/net/prediction_options.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
Expand All @@ -20,6 +21,10 @@
#include "components/gcm_driver/gcm_channel_status_syncer.h"
#endif

#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
#include "brave/components/brave_wayback_machine/pref_names.h"
#endif

using BraveProfilePrefsBrowserTest = InProcessBrowserTest;

// Check download prompt preference is set to true by default.
Expand All @@ -45,6 +50,10 @@ IN_PROC_BROWSER_TEST_F(BraveProfilePrefsBrowserTest, MiscBravePrefs) {
browser()->profile()->GetPrefs()->GetBoolean(kLinkedInEmbedControlType));
EXPECT_TRUE(
browser()->profile()->GetPrefs()->GetBoolean(kWebTorrentEnabled));
#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
EXPECT_TRUE(browser()->profile()->GetPrefs()->
GetBoolean(kBraveWaybackMachineEnabled));
#endif
EXPECT_TRUE(
browser()->profile()->GetPrefs()->GetBoolean(kHangoutsEnabled));
EXPECT_FALSE(
Expand Down
9 changes: 9 additions & 0 deletions browser/brave_tab_helpers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "brave/components/brave_rewards/browser/buildflags/buildflags.h"
#include "brave/components/brave_shields/browser/brave_shields_web_contents_observer.h"
#include "brave/components/brave_shields/browser/buildflags/buildflags.h" // For STP
#include "brave/components/brave_wayback_machine/buildflags.h"
#include "brave/components/greaselion/browser/buildflags/buildflags.h"
#include "content/public/browser/web_contents.h"
#include "third_party/widevine/cdm/buildflags.h"
Expand All @@ -36,6 +37,10 @@
#include "brave/browser/brave_drm_tab_helper.h"
#endif

#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
#include "brave/browser/infobars/brave_wayback_machine_delegate_impl.h"
#endif

namespace brave {

void AttachTabHelpers(content::WebContents* web_contents) {
Expand Down Expand Up @@ -67,6 +72,10 @@ void AttachTabHelpers(content::WebContents* web_contents) {
BraveDrmTabHelper::CreateForWebContents(web_contents);
#endif

#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
BraveWaybackMachineDelegateImpl::AttachTabHelperIfNeeded(web_contents);
#endif

brave_ads::AdsTabHelper::CreateForWebContents(web_contents);
}

Expand Down
7 changes: 5 additions & 2 deletions browser/extensions/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import("//brave/browser/tor/buildflags/buildflags.gni")
import("//brave/components/brave_rewards/browser/buildflags/buildflags.gni")
import("//brave/components/brave_sync/buildflags/buildflags.gni")
import("//brave/components/brave_wallet/browser/buildflags/buildflags.gni")
import("//brave/components/brave_wayback_machine/buildflags/buildflags.gni")
import("//brave/components/brave_webtorrent/browser/buildflags/buildflags.gni")
import("//build/config/features.gni")
import("//components/gcm_driver/config.gni")
Expand Down Expand Up @@ -61,13 +62,15 @@ source_set("extensions") {
deps = [
"//base",
"//brave/app:brave_generated_resources_grit",
"//brave/browser/tor:buildflags",
"//brave/browser/webcompat_reporter",
"//brave/common",
"//brave/common:pref_names",
"//brave/common/extensions/api",
"//brave/components/brave_component_updater/browser",
"//brave/components/brave_extension:generated_resources",
"//brave/components/brave_extension:static_resources",
"//brave/components/brave_wayback_machine:buildflags",
"//chrome/browser/extensions",
"//components/gcm_driver:gcm_driver",
"//components/gcm_driver:gcm_buildflags",
Expand Down Expand Up @@ -115,9 +118,9 @@ source_set("extensions") {
"brave_webtorrent_navigation_throttle.h",
]
}
if (enable_tor) {
if (enable_brave_wayback_machine) {
deps += [
"//brave/browser/tor:buildflags",
"//brave/components/brave_wayback_machine",
]
}
}
Expand Down
11 changes: 5 additions & 6 deletions browser/extensions/api/brave_wallet_api_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ class BraveWalletAPIBrowserTest : public InProcessBrowserTest,
for (size_t i = 0; i < infobar_service->infobar_count(); i++) {
InfoBarDelegate* delegate =
infobar_service->infobar_at(i)->delegate();
if (delegate->GetIdentifier() == (InfoBarDelegate::InfoBarIdentifier)
CRYPTO_WALLETS_INFOBAR_DELEGATE) {
if (delegate->GetIdentifier() ==
InfoBarDelegate::CRYPTO_WALLETS_INFOBAR_DELEGATE) {
ConfirmInfoBarDelegate* confirm_delegate =
delegate->AsConfirmInfoBarDelegate();
// Only the OK button should be present
Expand All @@ -118,8 +118,8 @@ class BraveWalletAPIBrowserTest : public InProcessBrowserTest,
for (size_t i = 0; i < infobar_service->infobar_count(); i++) {
InfoBarDelegate* delegate =
infobar_service->infobar_at(i)->delegate();
if (delegate->GetIdentifier() == (InfoBarDelegate::InfoBarIdentifier)
CRYPTO_WALLETS_INFOBAR_DELEGATE) {
if (delegate->GetIdentifier() ==
InfoBarDelegate::CRYPTO_WALLETS_INFOBAR_DELEGATE) {
ConfirmInfoBarDelegate* confirm_delegate =
delegate->AsConfirmInfoBarDelegate();
// Only the OK button should be present
Expand Down Expand Up @@ -148,8 +148,7 @@ class BraveWalletAPIBrowserTest : public InProcessBrowserTest,
void OnInfoBarAdded(InfoBar* infobar) override {
if (infobar_added_run_loop_ &&
infobar->delegate()->GetIdentifier() ==
(InfoBarDelegate::InfoBarIdentifier)
CRYPTO_WALLETS_INFOBAR_DELEGATE) {
InfoBarDelegate::CRYPTO_WALLETS_INFOBAR_DELEGATE) {
infobar_added_ = true;
infobar_added_run_loop_->Quit();
}
Expand Down
9 changes: 9 additions & 0 deletions browser/extensions/api/settings_private/brave_prefs_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "brave/browser/extensions/api/settings_private/brave_prefs_util.h"

#include "brave/common/pref_names.h"
#include "brave/components/brave_wayback_machine/buildflags.h"
#include "chrome/browser/extensions/api/settings_private/prefs_util.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/extensions/api/settings_private.h"
Expand All @@ -16,6 +17,10 @@
#include "components/gcm_driver/gcm_channel_status_syncer.h"
#endif

#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
#include "brave/components/brave_wayback_machine/pref_names.h"
#endif

namespace extensions {

namespace settings_api = api::settings_private;
Expand Down Expand Up @@ -90,6 +95,10 @@ const PrefsUtil::TypedPrefMap& BravePrefsUtil::GetWhitelistedKeys() {
// WebTorrent pref
(*s_brave_whitelist)[kWebTorrentEnabled] =
settings_api::PrefType::PREF_TYPE_BOOLEAN;
#if BUILDFLAG(ENABLE_BRAVE_WAYBACK_MACHINE)
(*s_brave_whitelist)[kBraveWaybackMachineEnabled] =
settings_api::PrefType::PREF_TYPE_BOOLEAN;
#endif
// Hangouts pref
(*s_brave_whitelist)[kHangoutsEnabled] =
settings_api::PrefType::PREF_TYPE_BOOLEAN;
Expand Down
13 changes: 12 additions & 1 deletion browser/infobars/BUILD.gn
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import("//build/config/features.gni")
import("//brave/components/brave_wayback_machine/buildflags/buildflags.gni")

source_set("infobars") {
sources = [
"brave_confirm_p3a_infobar_delegate.cc",
"brave_confirm_p3a_infobar_delegate.h",
"brave_infobar_delegate.h",
"crypto_wallets_infobar_delegate.cc",
"crypto_wallets_infobar_delegate.h",
]
Expand All @@ -23,4 +23,15 @@ source_set("infobars") {
"//ui/views",
"//url",
]

if (enable_brave_wayback_machine) {
sources += [
"brave_wayback_machine_delegate_impl.cc",
"brave_wayback_machine_delegate_impl.h",
]

deps += [
"//brave/components/brave_wayback_machine",
]
}
}
2 changes: 1 addition & 1 deletion browser/infobars/brave_confirm_p3a_infobar_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ BraveConfirmP3AInfoBarDelegate::~BraveConfirmP3AInfoBarDelegate() {}

infobars::InfoBarDelegate::InfoBarIdentifier
BraveConfirmP3AInfoBarDelegate::GetIdentifier() const {
return (InfoBarIdentifier)BRAVE_CONFIRM_P3A_INFOBAR_DELEGATE;
return BRAVE_CONFIRM_P3A_INFOBAR_DELEGATE;
}

const gfx::VectorIcon& BraveConfirmP3AInfoBarDelegate::GetVectorIcon() const {
Expand Down
2 changes: 0 additions & 2 deletions browser/infobars/brave_confirm_p3a_infobar_delegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "url/gurl.h"

#include "brave/browser/infobars/brave_infobar_delegate.h"

class InfoBarService;
class PrefService;

Expand Down
Loading